typo in NXparameters

[prjemian]

In the NXparameters definition, term should be all caps (meaning that any valid field name could be used). Also, the data type should be completely flexible (such as NX_CHAR_OR_NUMBER).

definitions/base_classes/NXparameters.nxdl.xml

Line 30 in 69f92a3

<field name="term" minOccurs="0" maxOccurs="unbounded" type="NX_CHAR">

[rayosborn]

I think it's worth specifying allowed attributes of TERM as well. In NeXpy, we use "error", "initial_value", "max", "min", "vary" (i.e., True if it was fitted), and "expr". The last contains a string that the LMFIT package uses to constrain parameters by expressions involving the other parameters. This might be tricky to put in a definition, because we've had a lot of trouble defining functions in NeXus and the function here is defined by an external package (LMFIT). The variables in the expression also refer to the names of functions defined outside the group, so we would probably have to leave "expr" out, but the others are more generally valid.

[prjemian]

PR #1039 has been advised to use NXparameters. This change would better inform them about the as-defined term field.

[prjemian]

@rayosborn Is your comment about this base class in general, or specific to some application definition?

[rayosborn]

I think it is appropriately general to be added to the base class, but we obviously need to get some feedback from others. I guess that's what PRs are for. These attributes have been in place for many years in NeXpy, so it's possible that there have been some changes to allowed NeXus attributes that are relevant.

[prjemian]

Also, we should note that any and all content within a NXcollection group specified by an application definition cannot be validated. NXcollection is and will always be for unvalidated content. This should be made clear in future NIAC reviews of contributed definitions and made clear in the documentation of NXcollection, with a suggestion to use NXparameters instead.

[tacaswell]

This has been addressed by #1402

definitions/base_classes/NXparameters.nxdl.xml

Lines 30 to 33 in 9059815

	<field name="TERM" minOccurs="0" maxOccurs="unbounded" nameType="any">
	<!-- maxOccurs="unbounded" is intended but is not allowed by current syntax -->
	<doc>A parameter (also known as a term) that is used in or results from processing.</doc>
	<attribute name="units"/>