-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve address scoring in latlng_to_address()
#16
Comments
Sampling some places demonstrates that it is NOT straightforward in any way. For some, the plus_code was the best, others, premise, others street_address. Each result also has a Anyway, the only place that uses this information is when we generate a KML file for the optimal route, and we are unable to do that right now anyway because the old libraries no long exist. Figuring out if closest result is best would currently depend on So, this is a pretty low priority item at the moment. |
A place like Some results have |
Seeing cases where there is also a `plus_code` in the results, and tend to be useless around boundaries, like for counties. Issue #16.
I have at least one example where the reverse geocoding picks a really bad result.
https://developers.google.com/maps/documentation/geocoding/requests-reverse-geocoding
Right now we only allow a
result_type
of street_address, but with my example, premise is MUCH better. In particular, the good has alocation_type
of ROOFTOP while the other had RANGE_INTERPOLATED.But, from a set of one, it is not yet possible to determine that premise is always better than street_address. More testing is needed.
Also, currently, scores are a simple summation of weights. A tuple-like solution would probably be better. Also, switch from a dictionary of weights to proper enums.
The text was updated successfully, but these errors were encountered: