Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiqc metrics #14

Merged
merged 4 commits into from
Apr 23, 2024
Merged

Multiqc metrics #14

merged 4 commits into from
Apr 23, 2024

Conversation

nvnieuwk
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@nvnieuwk nvnieuwk requested a review from mvheetve April 23, 2024 10:57
mvheetve
mvheetve approved these changes Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@mvheetve mvheetve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very small review :D All good!

@nvnieuwk
Copy link
Member Author

Thanks the test fail though oops!

@nvnieuwk nvnieuwk mentioned this pull request Apr 23, 2024
Closed
9 tasks
@nvnieuwk nvnieuwk requested a review from mvheetve April 23, 2024 13:13
@nvnieuwk
Copy link
Member Author

@mvheetve can you take another look please :)

mvheetve
mvheetve approved these changes Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@mvheetve mvheetve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nvnieuwk
Copy link
Member Author

Thanks!

@nvnieuwk nvnieuwk merged commit 2503ada into dev Apr 23, 2024
2 of 4 checks passed
@nvnieuwk nvnieuwk deleted the multiqc-metrics branch April 23, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvheetve mvheetve mvheetve approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nvnieuwk @mvheetve