Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WIPERTOOLS #7300

Merged
merged 5 commits into from
Jan 14, 2025
Merged

Update WIPERTOOLS #7300

merged 5 commits into from
Jan 14, 2025

Conversation

mazzalab
Copy link
Contributor

  • Just channel names renaming
  • Update test snapshots
  • Fix linting in fastqgather's meta.yaml

PR checklist

Closes #7298

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda

@mazzalab mazzalab self-assigned this Jan 13, 2025
@mazzalab mazzalab added the WIP Work in progress label Jan 13, 2025
@mazzalab mazzalab requested a review from a team as a code owner January 13, 2025 20:52
@mazzalab mazzalab removed the request for review from a team January 13, 2025 21:19
Copy link
Contributor

@lpantano lpantano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all is pretty good. I don't know If there is a way to notify pipelines importing this module that emit channel names are changing now, because I guess it will break the pipeline calling these modules when updating the module.

@mazzalab
Copy link
Contributor Author

Thanks @lpantano I don't know either. I'll ask around

@mazzalab mazzalab added this pull request to the merge queue Jan 14, 2025
Merged via the queue into nf-core:master with commit c9e9241 Jan 14, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update module: WIPERTOOLS
2 participants