Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge template v2.10 #117

Merged
merged 4 commits into from
Sep 27, 2023
Merged

Merge template v2.10 #117

merged 4 commits into from
Sep 27, 2023

Conversation

JoseEspinosa
Copy link
Member

Merge template v2.10

PR checklist

  • This comment contains a description of changes (with reason).
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • CHANGELOG.md is updated.

@github-actions
Copy link

github-actions bot commented Sep 26, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit aae18b5

+| ✅ 149 tests passed       |+
#| ❔   3 tests were ignored |#
!| ❗  12 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: conf/igenomes.config
  • files_exist - File not found: lib/WorkflowProteinfold.groovy
  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).
  • pipeline_todos - TODO string in check_samplesheet.py: Update the script to check the samplesheet
  • pipeline_todos - TODO string in check_samplesheet.py: Update the check_samplesheet function
  • pipeline_todos - TODO string in check_samplesheet.py: Update the column names for the input samplesheet
  • pipeline_todos - TODO string in WorkflowAlphafold2.groovy: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in WorkflowMain.groovy: Add Zenodo DOI for pipeline after first release
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in usage.md: Add documentation about anything specific to running your pipeline. For general topics, please point to (and add to) the main nf-core website.
  • pipeline_todos - TODO string in base.config: Check the defaults for all processes
  • pipeline_todos - TODO string in base.config: Customise requirements for specific processes.

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/bug_report.yml
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore or pyproject.toml
  • multiqc_config - multiqc_config

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-09-26 12:45:53

@JoseEspinosa JoseEspinosa marked this pull request as ready for review September 26, 2023 12:46
@JoseEspinosa JoseEspinosa merged commit e9fad86 into nf-core:dev Sep 27, 2023
9 checks passed
@JoseEspinosa JoseEspinosa deleted the merge_temp_2.10 branch September 27, 2023 09:17
@maxulysse
Copy link
Member

zenodo link in README was wrong, missed that bit before, sorry

@JoseEspinosa
Copy link
Member Author

Yes, just saw your comment on atacseq, good spot thanks!

@JoseEspinosa JoseEspinosa mentioned this pull request Sep 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoseEspinosa @maxulysse @nf-core-bot