-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multiome support (scATAC + scRNA) #174
Comments
Could you elaborate on how the samplesheet would need to look like? If it's just about having additional columns, I think it would be fine. More general, we should think about which modalities (ATAC, CITE, VDJ, spatial, ...) we want to support in the future and which should be processed by the same workflow. |
I will implement cellranger-arc in scrnaseq and then see how it goes. But yes, it would be nice to discuss the modalities. |
Would still be great to discuss here before merging an entire subworkflow first 😉 |
Technically cellranger-arc needs a samplesheet (lib.cv) as an input which looks likes this:
Thus, lib.csv defines the folder locations for the scRNA and scATAC for the sample. My thinking was the following:
This approach has two advantages:
|
Personally I like to have all files explicitly listed in the samplesheet, also for consistency with other aligners. Possible alternative:
|
Works for me. |
Tendency to go for the option proposed by @grst as it will not break existing solutions / setup 👍🏻 |
Perfect. Then I am on it! |
A bit of a question remains for me how we should generally work with these multi-ome analysis types: scrnaseq (as per name suggests ;-)) is for sc-rna analysis, if we continue to add more types of analyses we might have overlaps with other nf-core pipelines (atacseq, ...) - maybe something I will put up for discussion on the general nf-core slack how to deal with these sort of things in the future 👍🏻 |
Thanks @apeltzer. Indeed, also for findability, because users might not immediately realize that you could use scrnaseq for scATAC and multiome. |
Link to discussion on Slack also added here to do proper x-ref: https://nfcore.slack.com/archives/CE4K7FEHE/p1667987775811819 |
Please chime in there too - there is some opinions out there. |
The corresponding module has been merged: |
both cellranger-arc and cellranger-multi are implemented. |
Description of feature
Just wanted to put it down and mention that I am currently working on the implementation of cellranger-arc (modules + subworkflow). Maybe worth to discuss if this is fine to integrate into scranseq or if his should be an own pipeline as it requires a different sample sheet format and different input checks.
The text was updated successfully, but these errors were encountered: