Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include --expect-cells when using --aligner cellranger #182

Open
adairama opened this issue Nov 11, 2022 · 3 comments
Open

Include --expect-cells when using --aligner cellranger #182

adairama opened this issue Nov 11, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@adairama
Copy link

Description of feature

As discussed in the Slack Channel for scrna-seq on 23rd September 2022:

It will be good to allow --expect-cells in the run with --aligner cellranger option for scrnaseq pipeline. Since the expected cells can vary between samples (e.g. 6000 for sample 1, 3000 for sample 2), it will be good have this as a column in the sample metadata.

Gregor Sturm suggested related issue:
#90 (comment)

@adairama adairama added the enhancement New feature or request label Nov 11, 2022
@apeltzer
Copy link
Member

CellRanger v.7 (which is included inthe pipeline) should auto-detect this btw, so actually not really needed. Not sure if its more accurate if we specify it (and what happens if we specify a wrong value here?).

@grst grst added this to scrnaseq Feb 21, 2023
@github-project-automation github-project-automation bot moved this to Todo in scrnaseq Feb 21, 2023
@grst
Copy link
Member

grst commented Mar 13, 2023

also universc should consume the expected_cells column. I suggest to add a value auto as default for cellranger.

@grst grst removed this from scrnaseq Nov 7, 2024
@grst
Copy link
Member

grst commented Nov 7, 2024

Even if it might not be necessary for cellranger, this flag should behave correctly and pass the value if it's specified to all aligners that support it. The default should be auto.

Universc shall be removed, see #289

@grst grst added this to scrnaseq Nov 7, 2024
@github-project-automation github-project-automation bot moved this to Todo high priority in scrnaseq Nov 7, 2024
@grst grst moved this from Todo high priority to Todo - medium priority in scrnaseq Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo - medium priority
Development

No branches or pull requests

3 participants