Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update monitor annotations job to use contentType=dataset filtering #81

Open
anngvu opened this issue Mar 5, 2024 · 2 comments
Open

Comments

@anngvu
Copy link
Contributor

anngvu commented Mar 5, 2024

Context and user story:

In September 2022, the first version of annotations reminder was implemented via #25.
In March 2023, we switched over to schematic's preferred way of using contentType=dataset in #50.

The logic of monitor annotations currently aligns more with ProjectLive, which does not use the contentType=dataset to do a pre-selection of data assets first; selection of data to pay attention to is primarily based on resourceType. But ProjectLive will soon go away anyway, to be replaced by DataFlow, and the views will look different and indeed be more focused on contentType=dataset folders. So it is likely better if reminders be consistent with DataFlow (and DCA) by using the contentType=dataset selection approach.

Other reasons to revise approach:

  • Simpler and easier to take advantage of labels added on folders that weren't there before, and reduce the current inferencing/pattern matching needed.

Raised by @cconrad8, open for comments by @allaway and @jaybee84.

@allaway
Copy link
Contributor

allaway commented Mar 5, 2024 via email

@cconrad8
Copy link
Contributor

cconrad8 commented Mar 5, 2024

I also agree! Thanks for writing it out

@anngvu anngvu moved this to Todo in NF-OSI Sprints Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

3 participants