k8s.ReplaceNamespacedCustomObject() extension isn't working

[jefflill]

The k8s.ReplaceNamespacedCustomObject() extension method is failing with UnprocessableEntity errors. This is probably happening with the cluster custom objects as well. This is impacting our Upsert related methods when the resource already exists. The base k8s.ReplaceNamespacedCustomObject() isn't documented anymore for .NET and is barely documented for other languages.

Perhaps we can use one of the patch related methods instead.

[marcusbooyah]

Where is it not working?

[jefflill]

Here's a simple repro (an existing cluster is required):

using k8s;
using k8s.Models;

using Neon.Kube;
using Neon.Kube.K8s;
using Neon.Kube.Resources.Istio;

namespace test
{
    internal class Program
    {
        static async Task Main(string[] args)
        {
            var k8s       = new Kubernetes(KubernetesClientConfiguration.BuildDefaultConfig());
            var telemetry = new V1Telemetry()
            {
                Metadata = new V1ObjectMeta()
                {
                    Name              = "upsert-test",
                    NamespaceProperty = "default"
                },
                Spec = new V1TelemetrySpec()
                {
                    Tracing = new List<Tracing>()
                    {
                        new Tracing()
                        {
                            Providers = new List<TracingProvider>()
                            {
                                new TracingProvider()
                                {
                                    Name = "opencensus"
                                }
                            },
                            RandomSamplingPercentage = 1.0
                        }
                    }
                }
            };

            // This creates the resource.

            await k8s.CustomObjects.UpsertNamespacedCustomObjectAsync<V1Telemetry>(telemetry, name: telemetry.Name(), namespaceParameter: telemetry.Namespace());

            // This should update the resource, but fails.

            telemetry.Spec.Tracing[0].RandomSamplingPercentage = 100.0;

            await k8s.CustomObjects.UpsertNamespacedCustomObjectAsync<V1Telemetry>(telemetry, name: telemetry.Name(), namespaceParameter: telemetry.Namespace());
        }
    }
}

...and here's the error:

Operation returned an invalid status code 'UnprocessableEntity', response body {"kind":"Status","apiVersion":"v1","metadata":{},"status":"Failure","message":"telemetries.telemetry.istio.io \"upsert-test\" is invalid: metadata.resourceVersion: Invalid value: 0x0: must be specified for an update","reason":"Invalid","details":{"name":"upsert-test","group":"telemetry.istio.io","kind":"telemetries","causes":[{"reason":"FieldValueInvalid","message":"Invalid value: 0x0: must be specified for an update","field":"metadata.resourceVersion"}]},

Looks like we need to pass the original resource's resourceVersion. I spent a couple minutes playing around with that but then set it aside to look at later.

I noticed this when single-stepping through the V1Telemetry creation in namespaces code during cluster setup, when I quit debugging after one resource was created and then restarted setup and I expected that it would just update the first existing resource and then finish creating the other resources. But the upsert call failed on that existing resource.

I've worked around this by using CreateNamespacedCustomObjectAsync() and protecting each with an InvokeIdempotentAsync().

[marcusbooyah]

Fixed