Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uninstall Protractor Package #3

Open
gpincheiraa opened this issue Dec 23, 2019 · 0 comments
Open

Uninstall Protractor Package #3

gpincheiraa opened this issue Dec 23, 2019 · 0 comments
Labels
cypress-cucumber-schematics Cypress Cucumber Schematics related issues enhancement New feature or request

Comments

@gpincheiraa
Copy link
Contributor

The schematic only remove files related to e2e test from e2e folder but not uninstall dependencies from Angular project when the schematic were running.

Expected Behaviour

A new Rule should be generated in the schematic implementation like addCypressCucumberDependencies
https://github.com/ngChile/ngchile-packages/blob/master/packages/cypress-cucumber-schematics/src/schematics/cypress/index.ts#L26
but for remove dependencies.

Implementation Ideas
The Rule could be named as removeCypressCucumberDependencies . For implement it you can use the Test file that will be create a Virtual File Storage for check if the dependency was installed.
Look this file:
https://github.com/ngChile/ngchile-packages/blob/master/packages/cypress-cucumber-schematics/src/schematics/cypress/index.spec.ts#L63
We can create similar assertion for check that protractor package is not present on package.json file.

@gpincheiraa gpincheiraa added enhancement New feature or request cypress-cucumber-schematics Cypress Cucumber Schematics related issues labels Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cypress-cucumber-schematics Cypress Cucumber Schematics related issues enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant