Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong argument name in soma_processor #16

Open
simon-schaefer opened this issue Aug 12, 2022 · 0 comments
Open

Wrong argument name in soma_processor #16

simon-schaefer opened this issue Aug 12, 2022 · 0 comments

Comments

@simon-schaefer
Copy link

Hi,

first of all, thank you for publishing and releasing such an awesome work to the public!
While looking at the code I have noticed a small mismatch of function arguments. In soma/src/soma/tools/soma_processor.py:451 you call the function write_mocap_c3d with the wrong argument. It should be out_mocap_fname not out_c3d_fname, so

    if rt_cfg.save_c3d:
        c3d_out_fname = rt_cfg.dirs.mocap_out_fname.replace('.pkl', '.c3d')
        nan_replaced_labels = [l if l != 'nan' else '*{}'.format(i) for i, l in enumerate(results['labels'])]
        write_mocap_c3d(out_mocap_fname=c3d_out_fname,
                        markers=results['markers'],
                        labels=nan_replaced_labels,
                        frame_rate=soma_labeler.mocap_frame_rate)
        logger.info(f'Created {c3d_out_fname}')

Happy to do a small PR to fix this as well :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant