fix: ansible versions validation tasks #841
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ All required contributors have signed the F5 CLA for this PR. Thank you! |
fix nginxinc#840 Since a6712e3, ansible and jinja versions are validated to ensure supported versions are used. This validation is done by delegating `command` tasks to localhost, and parsing the standard output of the executed commands, e.g. `ansible --version`. The `ansible.builtin.command` module is not run when in check mode, causing the variable which is supposed to get the result of the command to be empty, resulting in an error message in the following tasks that parse these result variables. This commit ensures the `command` tasks are run even in check_mode. As they do no modification on localhost, this is not dangerous. Signed-off-by: Alexis Thietard <[email protected]>
Al-thi
force-pushed
the
fix/versions-validation
branch
from
3c50a6e to
cab6adb
Compare
|
I have hereby read the F5 CLA and agree to its terms |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
fix #840
Since a6712e3, ansible and jinja versions are validated to ensure supported versions are used.
This validation is done by delegating
commandtasks to localhost, and parsing the standard output of the executed commands, e.g.ansible --version.The
ansible.builtin.commandmodule is not run when in check mode, causing the variable which is supposed to get the result of the command to be empty, resulting in an error message in the following tasks that parse these result variables.This commit ensures the
commandtasks are run even in check_mode. As they do no modification on localhost, this is not dangerous.Checklist
Before creating a PR, run through this checklist and mark each as complete:
defaults/main/*.yml,README.mdandCHANGELOG.md).