You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At present templates are managed separately from the NIC Go binary. Embedding (reference) them into the binary would provide following benefits:
TemplateExecutor would always have access to the original templates; no need to keep track of template's content (state) internally (inside the executor stuct) when users use custom templates (via ConfigMaps)
no need to read content of files at startup as the files content is processed at compile time
remove the need to manage static files while building Docker images
for example:
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
At present templates are managed separately from the NIC Go binary. Embedding (reference) them into the binary would provide following benefits:
TemplateExecutor
would always have access to the original templates; no need to keep track of template's content (state) internally (inside the executor stuct) when users use custom templates (via ConfigMaps)for example:
https://github.com/nginxinc/kubernetes-ingress/blob/5108b30904954e1707c6bb48471d727cb161adca/build/Dockerfile#L666L670
https://github.com/nginxinc/kubernetes-ingress/blob/5108b30904954e1707c6bb48471d727cb161adca/build/Dockerfile#L714L718
https://github.com/nginxinc/kubernetes-ingress/blob/5108b30904954e1707c6bb48471d727cb161adca/build/Dockerfile#L763L766
Users could still use their custom templates when:
Beta Was this translation helpful? Give feedback.
All reactions