Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default imagePullPolicy name when using NGINX Plus #2837

Open
sjberman opened this issue Nov 27, 2024 · 0 comments
Open

Set default imagePullPolicy name when using NGINX Plus #2837

sjberman opened this issue Nov 27, 2024 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@sjberman
Copy link
Contributor

sjberman commented Nov 27, 2024

By default, our docs have users create the docker registry secret with the name nginx-plus-registry-secret. But we don't use this default in our actual installation. We force users to specify it.

We should use this default name in our installation to reduce the amount of fields that a user has to specify if they copy installation steps straight from the docs.

Acceptance

  • If using NGINX Plus, the default imagePullSecret name is set to nginx-plus-registry-secret.
  • Installation docs are updated to no longer include this field in the command examples.
@sjberman sjberman added the enhancement New feature or request label Nov 27, 2024
@sindhushiv sindhushiv added this to the v2.0.0 milestone Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🆕 New
Development

No branches or pull requests

2 participants