-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Normalize location path to avoid multiple forward slashes & fix docs #99
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR! The integration tests are failing with the new changes. Can you please modify the integration tests such that they test for the new functionality?
I've been doing some research on how to fix the integration tests and I've been unable to find a method of normalizing slashes using rewrite rules that will preserve the requested schema, hostname, and port. I think we may have to implement this in njs. I did a prototype in njs and it was relatively simple to normalize the uri requested to S3, but it does not result in a HTTP 302 redirect to the client. I'll update as I discover more. |
I have not taken a a look yet at the integration tests yet, but if the njs solution serves the content correctly even if it doesn't rewrite the URL / redirect in the client I think that's a valid solution. In a previous unsuccessful attempt in njs I was getting 404 errors after normalising "uri_path" variable. |
0cd76e7
to
e6f9460
Compare
I tried updating the integration tests to expect a 302 code redirect when there is a double slash, but I am getting a error code return 7 from the run, without much detail |
@dav-pascual - I'm traveling right now, so it will be a while until I can engage on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed
Fixes: #88 and docs