Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add common data with the scheme #8

Closed
pleshakov opened this issue Feb 2, 2024 · 1 comment
Closed

Add common data with the scheme #8

pleshakov opened this issue Feb 2, 2024 · 1 comment
Assignees
@pleshakov
Milestone
v0.1.0

Comments

@pleshakov
Copy link
Contributor

pleshakov commented Feb 2, 2024 •
edited
Loading

Add a type that includes common data points for Kubernetes projects that can be used both by NGF and NIC.
This will ensure consistent metrics among the projects.
@pleshakov pleshakov added the enhancement Pull requests for new features/feature enhancements label Feb 2, 2024
@pleshakov pleshakov removed the enhancement Pull requests for new features/feature enhancements label Feb 26, 2024
@pleshakov pleshakov self-assigned this Feb 26, 2024
@pleshakov pleshakov added the blocked Issues that are blocked by external factors label Feb 28, 2024
@pleshakov pleshakov mentioned this issue Feb 28, 2024
Merged
6 tasks
@pleshakov pleshakov removed the blocked Issues that are blocked by external factors label Feb 29, 2024
pleshakov added a commit that referenced this issue Feb 29, 2024
@pleshakov
Define common data points
2a35448 
Problem:
Ensure that our Kubernetes-related projects share common telemetry
data points for consistency.

Solution:
- Define common data points type.
- Generate Attributes() methods to allow using the type with the
Exporter (to implement Exportable interface).

A project that uses the exporter library will also export the
defined data type.

CLOSES - #8
pleshakov added a commit that referenced this issue Feb 29, 2024
@pleshakov
Define common data points
e852880 
Problem:
Ensure that our Kubernetes-related projects share common telemetry
data points for consistency.

Solution:
- Define common data points type.
- Generate Attributes() methods to allow using the type with the
Exporter (to implement Exportable interface).

A project that uses the exporter library will also export the
defined data type.

CLOSES - #8
pleshakov added a commit that referenced this issue Mar 5, 2024
@pleshakov @sjberman
Define common data points (#27)
6fef29d 
Problem:
Ensure that our Kubernetes-related projects share common telemetry
data points for consistency.

Solution:
- Define common data points type.
- Generate Attributes() methods to allow using the type with the
Exporter (to implement Exportable interface).

A project that uses the exporter library will also export the
defined data type.

CLOSES - #8

Co-authored-by: Saylor Berman <[email protected]>
@pleshakov
Copy link
Contributor Author

Implemented in #27

@lucacome lucacome added this to the v0.1.0 milestone Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pleshakov pleshakov

Labels
None yet
Projects
NGINX Gateway Fabric
Archived in project
Milestone
v0.1.0
Development

No branches or pull requests
2 participants
@lucacome @pleshakov