Is there an advantage of using PersistedQueryProvider

[luii]

Hey,

first of all i love it that you've comitted your time to create this fantastic adapter @NetanelBasal .
My Question is: is there an advantage using the PersistedQueryProvider over the QueryProvider with the keepPreviousData: true set?

I currently have a sort of abstract generic/shared service that gets extended by concrete services and i want to abstract the concept of having to type (like in inputting) the query keys manually away from the Developer, which on my end makes sense for the Application im developing.

public queryPaginatedEntities({filter, sort, pagination, projection}: Query<M>) {
    const queryKey = [this._modelQueryKey.plural, pagination]

    return this._useQuery(
      queryKey,
      () => {
        const body = {
          ...(filter && {$projection: JSON.stringify(filter)}),
          ...(sort && {$projection: JSON.stringify(sort)}),
          ...(pagination && {$projection: JSON.stringify(pagination)}),
          ...(projection && {$projection: JSON.stringify(projection)})
        };

        return this._httpClient.post<E[]>(
          `redacted`,
          body
        ).pipe(
          concatAll(),
          map(this._entityMapper.deserialize),
          toArray()
        )
      }, {
        keepPreviousData: true
      })
  }

In addition to the question above, is there any drawback of using this approach to query the entities?
Best regards

[NetanelBasal]

PersistedQueryProvider was needed for keepPreviousData to work. We need to persist the internal observer.

[luii]

Is there by any chance the possibility that it could use the same signature as useQuery, without exposing the queryKey to the Component?

[NetanelBasal]

I want to wait for TenStack query v5 because they will (finally) remove many of the overloads.

TanStack/query#4252

[NetanelBasal]

We can then explore the possibilities.

[luii]

Okay nice, i didn't knew that they're working on v5, thank you for the Link!
I think the way i solved it by adding the function call at the end should not change anything other than not exposing the query key and only expose the Filter, Sort, Pagination and Projection. Or is there a specific reasoning to expose it to the Component?

...

protected readonly _usePersistedQuery = inject(PersistedQueryProvider);

public queryEntities({filter, sort, pagination, projection}: Query<M>) {
    const queryKey = [this._modelQueryKey.plural, filter, sort, pagination, projection]

    const body = {
      ...
    };

    return this._usePersistedQuery((queryKey1) => {
      return queryOptions({
        queryKey: queryKey1,
        queryFn: () => this._httpClient.post<E[]>(`redacted`, body)
          .pipe(
            concatAll(),
            map(this._entityMapper.deserialize),
            toArray(),
          )
      })
    })(queryKey) // <--
  }

...

[NetanelBasal]

As long as you built it internally as you did, I don't think there should be an issue.