Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEO: Image too large #725

Open
blyonng opened this issue May 13, 2024 · 3 comments
Open

SEO: Image too large #725

blyonng opened this issue May 13, 2024 · 3 comments

Comments

@blyonng
Copy link
Contributor

blyonng commented May 13, 2024

I recommend adding a CICD step that will either fail builds with unoptimized images, will automatically optimize images, or a combination thereof.

The following images appear to be unoptimized, impacting page speed performance:

URL Size Load time
https://ngrok.com/docs/assets/images/ingress-controller-in-action-2-d38054b8990fe8c111b10312543ef345.gif 19192315 584
https://ngrok.com/docs/assets/images/ngrok-go-small-2f1d80b9bbe4aef22d3d3a291da8d2a7.gif 2794786 568
https://ngrok.com/docs/assets/images/1password-start-ngrok-f2f0995159ee27bc852d1f6335e3c427.gif 1788981 573
https://ngrok.com/docs/assets/images/curity-1-b27a5a0134c9139b54083c4da32a9e40.png 1155694 569
https://ngrok.com/docs/assets/images/client_disconnected-7724c4dbbc0f878a0135923839c22db7.png 1097326 552
@nijikokun
Copy link
Collaborator

nijikokun commented Jul 24, 2024

Definitely in favor of option 2. Is this the complete list of files?

@blyonng
Copy link
Contributor Author

blyonng commented Jul 24, 2024

Definitely in favor of option 2. Is this the complete list of files?

Yes, that's the complete list of files for now.

Those are the largest ones that are being flagged as problematic, but there are probably other large images in Docs that could benefit from optimization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants