filterNil() not working with FormControl correctly?

[dertuerke]

Hi, why vscode says that "orderBy" can be null?

sortParamsForm = new FormGroup({
  orderBy: new FormControl<ESyncOrderBy>(ESyncOrderBy.Name),
  orderSequence: new FormControl<EOrderSequence>(EOrderSequence.Ascending)
});

// (property) orderBy: FormControl<ESyncOrderBy | null>
this.sortParamsForm.controls.orderBy.valueChanges
  .pipe(
      filterNil(),
      takeUntilDestroyed()
  ).subscribe((orderBy) => {
  // (parameter) orderBy: NonNullable<ESyncOrderBy | null>
  this.syncListStore.updateQuery({ orderBy });
});

[msmallest]

edit: I missed the entire point that I would assume filterNil would handle that. Sorry.

https://angular.dev/guide/forms/typed-forms#formbuilder-and-nonnullableformbuilder`

By default, Angular form controls when you call .reset will revert to null. So since the control could be reset, the controls will include null.

Starting in Angular 14, there is now 3 ways you can prevent this

1. The closest to your way, new FormControl<ESyncOrderBy>(ESyncOrderBy.Name, { nonNullable: true })
2. Using an instance of FormBuilder, like fb = inject(FormBuilder) you can do this.fb.nonNullable.control(...)
3. Using an instance of NonNullableFormBuilder, like fb = inject(NonNullableFormBuilder) you can do this.fb.control(...).

This can be done on individual controls, so that should be sufficient for your use case. One thing to note: this cannot be done to a whole FormGroup instance, but you can make each control inside of it non-nullable.

edit:

• Another good link to the docs: https://angular.dev/guide/forms/typed-forms#nullability