Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a population dataset #95

Merged
merged 11 commits into from
Oct 18, 2024
Merged

Added a population dataset #95

merged 11 commits into from
Oct 18, 2024

Conversation

jacgrout
Copy link
Contributor

@jacgrout jacgrout commented Oct 17, 2024

Added a dataset of ONS Population Estimates for 2023 for the UK broken down by country, age, and sex

Closes #95

Co-authored-by: Tom Jemmett <[email protected]>
Co-authored-by: Gabriel Hobro<[email protected]>
Co-authored-by: Sarah Lucas<[email protected]>
@tomjemmett
Copy link
Member

Can you run devtools::document(), that should resolve the error.

There's a note about the all contributors file @Lextuga007 this should be in .Rbuildignore

@Lextuga007
Copy link
Member

I'm just fixing #86 😄

#' library(tidyverse)
#' library(tidyr)

#' Load the data in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#' Load the data in
#' # Load the data in

that line needs to be forced to be a comment: it's trying to run Load the data in as an R command

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, I would remove and change the entire example here:

  • the example is meant to be about using the data, not how to generate it
  • the example includes a path to a file on your local computer

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, thats all been fixed just now anyway, but still failing !

@Lextuga007
Copy link
Member

@tomjemmett I've asked @jacgrout to push the changes she's made and I can also have a look to see what's failing.

@tomjemmett tomjemmett merged commit 9236e43 into nhs-r-community:main Oct 18, 2024
2 checks passed
@Lextuga007
Copy link
Member

@all-contributors please add @jacgrout for data

Thank you for contributing such a major PR as part of #Hacktoberfest! 🎉

Copy link
Contributor

@Lextuga007

I've put up a pull request to add @jacgrout! 🎉

@Lextuga007 Lextuga007 added Hacktoberfest Perfect issues to contribute to the Hacktoberfest hacktoberfest accepted This PR was accepted as a good contribution for Hacktoberfest labels Oct 18, 2024
@Lextuga007 Lextuga007 linked an issue Oct 18, 2024 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest accepted This PR was accepted as a good contribution for Hacktoberfest Hacktoberfest Perfect issues to contribute to the Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more datasets
3 participants