Enum Support #5
Merged
Enum Support #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added ENUM support. This will only work if the different choices for the enum field are in the 0-127 ascii character set. I cannot promise that it will work if any of the enum choices are outside of that set.
|
Awesome, thanks! After I merged it in I played around with it a bit and made the following changes: I think with your change the 2nd commented-out block should be a 'continue' rather than 'break' so columns after that one would get converted too. Then I was thinking that while we could just skip the ENUM type entirely, it still "leaves" it in the old collation. I've updated the script again to just convert the ENUM data-type immediately without using a binary-conversion first. Thanks Patrick! |
|
Yeah, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ENUM support.
This will only work if the different choices for the enum field are in the 0-127 ascii character set. I cannot promise that it will work if any of the enum choices are outside of that set.
fixes #4