Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Clicking/Pressing a Piano Key No Longer Works #217

Open
nickytonline opened this issue Dec 23, 2024 · 1 comment
Open

Bug: Clicking/Pressing a Piano Key No Longer Works #217

nickytonline opened this issue Dec 23, 2024 · 1 comment

Comments

@nickytonline
Copy link
Owner

nickytonline commented Dec 23, 2024

Not sure when this happened as I always test dependency updates with the keyboard, but clicking the keys no longer finds the note to play. It's probably not a big fix, I just haven't had a chance to look into it yet.

CleanShot 2024-12-23 at 09 28 52

Here's the relevant code:

const { note } = (event.target as HTMLElement).dataset;
if (!note) {
throw new Error("No note found on key");
}
playNote(note as Note);
};

It looks like the data-note attribute gets set properly, so it's not that.

‹button class="text-sm flex flex-col bor er border-black rounded-sm bg-color-white active: scale-95 hover:bg-gray-300 w-10 m d:w-12 h-32 md:h-56" data-note="E4">c.• </button> (flex) == $0

Copy link

Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label.

To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take".

For full info on how to contribute, please check out our contributors guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant