Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updateTitle cannot be set to false #6

Open
chmp opened this issue Jan 16, 2017 · 0 comments
Open

updateTitle cannot be set to false #6

chmp opened this issue Jan 16, 2017 · 0 comments

Comments

@chmp
Copy link

chmp commented Jan 16, 2017

Thanks for this great library. Setting it up was extremely simple and it works like a charm. However, I ran into a problem while trying to set updateTitle to false:

The updateTitle config value is set via updateTitle = cfg.updateTitle || updateTitle;. This way the updateTitle config value cannot be set to false, since it then evaluates to its previous value (true). The corresponding line should be replaced via updateTitle = (cfg.updateTitle !== undefined) ? cfg.updateTitle : updateTitle;.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant