Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisions table breaks with Sequelize 5. #82

Open
createthis opened this issue Aug 19, 2019 · 1 comment
Open

Revisions table breaks with Sequelize 5. #82

createthis opened this issue Aug 19, 2019 · 1 comment

Comments

@createthis
Copy link
Contributor

createthis commented Aug 19, 2019 •
edited
Loading

This appears to be related to sequelize/sequelize#10717

If the revisionModel is Revisions, sequelize 5 has a bug and lowercases the table name as revisions in queries. This breaks sequelize-paper-trail.

I've found two potential solutions both added on

sequelize-paper-trail/lib/index.js

Line 637 in a0f0b6a

underscored: options.underscored,

  1. add freezeTableName: true,
  2. add tableName: options.tableName,
createthis added a commit to libertas-funding/sequelize-paper-trail that referenced this issue Aug 19, 2019
@createthis
Compensate for bug in upstream sequelize 5 where camelcase table names
ef26988 
are being rewritten as lowercase. nielsgl#82
@createthis createthis mentioned this issue Aug 19, 2019
Merged
@createthis
Copy link
Contributor Author

@nielsgl ^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@createthis