Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imposing boundaries on b-values (maximum, minimum) should be done by dataset (not model) #65

Open
oesteban opened this issue Jan 23, 2025 · 2 comments

Comments

@oesteban
Copy link
Member

The DWI dataset class should be responsible for deciding what's a b=0 and what are valid b values (given the minimum threshold) and likewise, saturate (given a maximum b) or manipulate (e.g., cluster b-values of a DSI into shells, clean up effective gradients that are close to the nominal value of a shell but not exactly) b-values when necessary.

I'm removing this feature from model in #62.

@oesteban
Copy link
Member Author

Similarly, adaptation of RAS+b and IJK+b should be handled elsewhere.

@jhlegarreta
Copy link
Contributor

Maybe a Filter should be in charge of doing this? I took the latter approach in PR #71.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants