Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider removing extra resampling #195

Closed
mgxd opened this issue May 26, 2020 · 2 comments
Closed

Consider removing extra resampling #195

mgxd opened this issue May 26, 2020 · 2 comments
Assignees
@mgxd
Milestone
0.7.0

Comments

@mgxd
Copy link
Collaborator

mgxd commented May 26, 2020

https://github.com/poldracklab/smriprep/blob/2ccfaaf582e0c948940e1505301942f89408460f/smriprep/workflows/surfaces.py#L518-L519

tonative should already produce a nii.gz file.
@mgxd mgxd mentioned this issue May 26, 2020
Merged
@oesteban
Copy link
Member

I agree with this, but it won't fix nipreps/fmriprep#2142 - the problematic file seems to be on standard space 'GLS005_ses-2_task-graphlocalizer_space-MNI152NLin2009cAsym_desc-aparcaseg_dseg.nii.gz', meaning that it is resampled with antsApplyTransforms later in the stream.

@oesteban oesteban added this to the 0.7.0 milestone May 28, 2020
@effigies
Copy link
Member

effigies commented Jun 7, 2020

Fixed in #201.

@effigies effigies closed this as completed Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mgxd mgxd

Labels
None yet
Projects
None yet
Milestone
0.7.0
Development

No branches or pull requests
3 participants
@effigies @oesteban @mgxd