New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker pushes fail on tags #330

Closed

effigies opened this issue Apr 4, 2023 · 1 comment · Fixed by #331

Labels

bug

Member

effigies commented Apr 4, 2023

Example: https://app.circleci.com/pipelines/github/nipreps/smriprep/678/workflows/efef46c8-1cfc-4448-9afe-438e3cebc733/jobs/3269

#!/bin/bash -eo pipefail
docker tag nipreps/smriprep nipreps/smriprep:${CIRCLE_BRANCH#docker/}
docker push nipreps/smriprep:${CIRCLE_BRANCH#docker/}

Error parsing reference: "nipreps/smriprep:" is not a valid repository/tag: invalid reference format
Exited with code exit status 1
CircleCI received exit code 1

effigies added the bug label

Collaborator

mgxd commented Apr 4, 2023

We should probably use the following heuristic:

check for CIRCLE_TAG
if none, check if CIRCLE_BRANCH has the docker/ prefix

mgxd mentioned this issue

CI: Prioritize tags on release #331

Merged

effigies closed this as completed in #331

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment