From 229f481cc3e6646fd69bf4163a065b7df2279a57 Mon Sep 17 00:00:00 2001 From: Tim Holm <tim.holm@nitric.io> Date: Thu, 20 Jul 2023 13:18:30 +1000 Subject: [PATCH 1/2] use noopspanprocessor for local run. --- src/faas/v0/traceProvider.ts | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/src/faas/v0/traceProvider.ts b/src/faas/v0/traceProvider.ts index 9e7f1db6..e84348f0 100644 --- a/src/faas/v0/traceProvider.ts +++ b/src/faas/v0/traceProvider.ts @@ -15,6 +15,7 @@ import { ConsoleSpanExporter, BatchSpanProcessor, NodeTracerProvider, + NoopSpanProcessor, } from '@opentelemetry/sdk-trace-node'; import { OTLPTraceExporter } from '@opentelemetry/exporter-trace-otlp-http'; import { Resource } from '@opentelemetry/resources'; @@ -51,13 +52,11 @@ const newTracerProvider = (): NodeTracerProvider => { tracerProvider: provider, }); - const traceExporter = localRun // If running locally - ? new ConsoleSpanExporter() - : new OTLPTraceExporter({ - url: 'http://localhost:4317', - }); - - const processor = new BatchSpanProcessor(traceExporter); + const processor = localRun + ? new NoopSpanProcessor() + : new BatchSpanProcessor(new OTLPTraceExporter({ + url: 'http://localhost:4317', + })); provider.addSpanProcessor(processor); provider.register(); From 6f917456fb5585f7aa94fb4cbab98ec5e46b40a9 Mon Sep 17 00:00:00 2001 From: Tim Holm <tim.holm@nitric.io> Date: Thu, 20 Jul 2023 13:20:31 +1000 Subject: [PATCH 2/2] prettier --- src/faas/v0/traceProvider.ts | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/faas/v0/traceProvider.ts b/src/faas/v0/traceProvider.ts index e84348f0..b97eff35 100644 --- a/src/faas/v0/traceProvider.ts +++ b/src/faas/v0/traceProvider.ts @@ -54,9 +54,11 @@ const newTracerProvider = (): NodeTracerProvider => { const processor = localRun ? new NoopSpanProcessor() - : new BatchSpanProcessor(new OTLPTraceExporter({ - url: 'http://localhost:4317', - })); + : new BatchSpanProcessor( + new OTLPTraceExporter({ + url: 'http://localhost:4317', + }) + ); provider.addSpanProcessor(processor); provider.register();