Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opting out to getPlayerInfo data to reduce ratelimits #830

Open
migue802 opened this issue Sep 3, 2024 · 1 comment · May be fixed by #840
Open

Opting out to getPlayerInfo data to reduce ratelimits #830

migue802 opened this issue Sep 3, 2024 · 1 comment · May be fixed by #840
Labels
enhancement New feature or request

Comments

@migue802
Copy link

migue802 commented Sep 3, 2024

Before posting a feature request, make sure that it hasn't been suggested before, is a feasible idea, and can benefit everyone.

Is your feature request related to a problem? Please describe.
While doing too many requests to getPlayerInfo, "friends.roblox.com" usually returns a 429, throwing a rejection and breaking stuff, due to the function doing 3 requests to that domain at once per getPlayerInfo call.

Describe the solution you'd like
I propose to do a opt-out to data I don't want to request. (A rate-limit handler would be great too but that would require much work than this I guess)
For eg., when doing tons of requests from users, I don't want to get friends or follower counts, neither username history, that would reduce processing time and avoid hitting ratelimits.

Describe alternatives you've considered
Another argument in getPlayerInfo where I can disable requests to "friends.roblox.com" and username history. For example:

noblox.getPlayerInfo(1, {friends: false, followings: false, followers: false, usernameHistory: false})

Additional context
N/A

@Neztore Neztore added the enhancement New feature or request label Sep 4, 2024
@Neztore
Copy link
Member

Neztore commented Sep 4, 2024

We've had some discussion around this in the past, and at the time our approach was going to be splitting each of those pieces of data into separate methods (which getPlayerInfo then calls) but it hasn't been actioned so far

@Regalijan Regalijan linked a pull request Oct 29, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants