TypeError when checking mime-types

[thinkverse]

Hello everyone.
I have an issue when trying to check for wrong mime-types, I have a simple function that checks if the mime-type is included in an array of mime-types, and responds with an 404 is type doesn't match, and otherwise I let formidable handle the file.

const isInvalidMimeType = fileMimeType => {
  let mimeTypes = [...]

  return (!mimeTypes.includes(fileMimeType)) ? true : false
}

form.onPart = function (part) {
  if (part.filename) {
    if (isInvalidMimeType(part.mime)) {
      return res.status(404).json({ 'status': 404, 'message': 'Wrong file type'})
    } else {
      form.handlePart(part)
    }
  }
}

My issue is that if it is the wrong filetype, formidable still tries to upload the file, so I get;

TypeError: Cannot read property 'path' of undefined

That error in turn kills the entire application, is there anyway to let formidable know that the file isn't suppose to be uploaded and just return the response?

You can find the whole project in here in this repo, repo:uploadz

[tunnckoCore]

is there anyway to let formidable know that the file isn't suppose to be uploaded and just return the response?

I'm pretty sure we discussed this in few issues for aborting/canceling the upload.

But for now, req.destroy() from #119 (comment) and #471

[thinkverse]

Thank you @tunnckoCore, returning req.destory() fixed the issue of the app destroying itself.

form.onPart = function (part) {
  if (part.filename) {
    if (isInvalidMimeType(part.mime)) {
      res.status(404).json({ 'status': 404, 'message': 'Wrong file type'})
      return req.destroy()
    } else {
      form.handlePart(part)
    }
  }
}

The fixed code it anyone wants it.

[tunnckoCore]

Great to hear that :)