Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behaviour change in fire statistics in v8.2.0 #894

Open
ullumullu opened this issue Oct 25, 2024 · 0 comments
Open

Behaviour change in fire statistics in v8.2.0 #894

ullumullu opened this issue Oct 25, 2024 · 0 comments

Comments

@ullumullu
Copy link

ullumullu commented Oct 25, 2024

I've discovered a small regression (?) which seems to have been introduced with #877 affecting disabled breakers.

Before

this.emit('fire', args);

The fire event was triggered for disabled breakers as well.

After

Moving the disablement check before the fire event changes the existing behaviour for disabled breakers.


I am not sure if this change was intentional - however it could lead to unwanted side effects for disabled breakers. Moving the emit call before the disablement check would revert the behaviour to the existing status.

Image

ullumullu added a commit to ullumullu/opossum that referenced this issue Oct 25, 2024
To revert to previous behaviour up to v8.1.4.

nodeshift#894
ullumullu added a commit to ullumullu/opossum that referenced this issue Oct 25, 2024
To revert to previous behaviour up to v8.1.4.

nodeshift#894
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant