From 8158eeb9ec52e306b805ae547b810576b364f18d Mon Sep 17 00:00:00 2001
From: Clemens Zagler <c.zagler@noi.bz.it>
Date: Tue, 19 Mar 2024 15:43:04 +0100
Subject: [PATCH] hotfix UMA denying station sync to everyone

---
 .../timeseries/bdp/writer/writer/JsonController.java      | 8 ++++----
 .../bdp/writer/writer/authz/AuthorizeSyncStation.java     | 4 ++--
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/writer/src/main/java/com/opendatahub/timeseries/bdp/writer/writer/JsonController.java b/writer/src/main/java/com/opendatahub/timeseries/bdp/writer/writer/JsonController.java
index 7b52896c..2bfd2e46 100644
--- a/writer/src/main/java/com/opendatahub/timeseries/bdp/writer/writer/JsonController.java
+++ b/writer/src/main/java/com/opendatahub/timeseries/bdp/writer/writer/JsonController.java
@@ -9,8 +9,6 @@
 import java.util.Date;
 import java.util.List;
 
-import jakarta.servlet.http.HttpServletRequest;
-
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.http.MediaType;
 import org.springframework.http.ResponseEntity;
@@ -24,14 +22,16 @@
 import org.springframework.web.bind.annotation.RestController;
 import org.springframework.web.servlet.support.ServletUriComponentsBuilder;
 
-import com.opendatahub.timeseries.bdp.writer.dal.util.JPAException;
-import com.opendatahub.timeseries.bdp.writer.writer.authz.AuthorizeSyncStation;
 import com.opendatahub.timeseries.bdp.dto.dto.DataMapDto;
 import com.opendatahub.timeseries.bdp.dto.dto.DataTypeDto;
 import com.opendatahub.timeseries.bdp.dto.dto.EventDto;
 import com.opendatahub.timeseries.bdp.dto.dto.ProvenanceDto;
 import com.opendatahub.timeseries.bdp.dto.dto.RecordDtoImpl;
 import com.opendatahub.timeseries.bdp.dto.dto.StationDto;
+import com.opendatahub.timeseries.bdp.writer.dal.util.JPAException;
+import com.opendatahub.timeseries.bdp.writer.writer.authz.AuthorizeSyncStation;
+
+import jakarta.servlet.http.HttpServletRequest;
 
 /**
  * Spring controller handling JSON requests to the writer API.
diff --git a/writer/src/main/java/com/opendatahub/timeseries/bdp/writer/writer/authz/AuthorizeSyncStation.java b/writer/src/main/java/com/opendatahub/timeseries/bdp/writer/writer/authz/AuthorizeSyncStation.java
index 36c3676b..de30f7b6 100644
--- a/writer/src/main/java/com/opendatahub/timeseries/bdp/writer/writer/authz/AuthorizeSyncStation.java
+++ b/writer/src/main/java/com/opendatahub/timeseries/bdp/writer/writer/authz/AuthorizeSyncStation.java
@@ -27,8 +27,8 @@ public static void authorize(HttpServletRequest req, String stationType, List<St
             boolean onlyActivation) {
         var authz = (Authorization) req.getAttribute(Authorization.ATTRIBUTE_AUTHORIZATION);
         if (authz == null) {
-            log.warn("No UMA authorization configuration found. Maybe your client credentials are incomplete or incorrect?");
-            throw new NotAuthorizedException("Not authorized");
+            // User is already authorized via role
+            return;
         }
         log.debug("Start authorizing station sync");