Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font types and sizes #116

Open
matax87 opened this issue Jun 30, 2022 · 7 comments
Open

Font types and sizes #116

matax87 opened this issue Jun 30, 2022 · 7 comments
Assignees

Comments

@matax87
Copy link
Collaborator

matax87 commented Jun 30, 2022

@MarE1991

Please integrate Font type and sizes accordingly:

  • Source Sans Pro Semibold
  • Source Sans Pro Regular

See noi-techpark/it.bz.noi.community.android#49

@matax87 matax87 changed the title Source Sans Pro Font types and sizes Jun 30, 2022
@MarE1991
Copy link
Collaborator

MarE1991 commented Jul 5, 2022

@lukasnagler can you help and check please :) thx

@lukasnagler
Copy link
Collaborator

The fontsize of the copytext on my android-mobile (app version: 01.0.1657010070) is well readable / big enough.
The white title in the black section-headers [Find your way! ... ] seems too big in my oppinion. @pkritzinger

@pkritzinger
Copy link
Collaborator

@Piiit unfortunately i cannot access the app anymore - I receive the following message. Could you pls verify? Thanks!^

image

@Piiit
Copy link
Contributor

Piiit commented Jul 12, 2022

@pkritzinger Should work now, please test... The reason is that we switched to our production auth server, if someone else of your team cannot access, just drop a mail or comment

@pkritzinger
Copy link
Collaborator

@Piiit - thanks a lot, works perfectly fine.

@lukasnagler I will check the fonts and let you know asap

@pkritzinger
Copy link
Collaborator

Hi @matax87 - overall the UI with the custom-font looks very good. We've found some potentials for optimization that I'll list below:

  • List view of Events (https://prnt.sc/Nx2ks9qIDMgN): can we reduce the font size to 25pt. line height 30pt?
  • Detail page Events (https://prnt.sc/AZhaCLxAWfwU): could you pls check the line height? We've foreseen 45pt here and it seems to be rather high in the app.
  • Eat (https://prnt.sc/er9G8tHq7pQo): the larger font type somehow "destroys" the button. Is there any option to fix it or shall we rethink the positioning of the button (e.g. below the opening hours)

@matax87
Copy link
Collaborator Author

matax87 commented Sep 19, 2022

Fixed in #127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants