Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in the opentables/tables strategy on Postgres Tourism DB should be reflected inside the Ontop mappings #45

Open
Piiit opened this issue Jun 10, 2021 · 5 comments
Assignees
Labels

Comments

@Piiit
Copy link
Contributor

Piiit commented Jun 10, 2021

Original Email by Rudi from 4/6/2021:

Selection_072

@Piiit Piiit self-assigned this Jun 10, 2021
@Piiit Piiit added the enhancement New feature or request label Jun 10, 2021
@Piiit
Copy link
Contributor Author

Piiit commented Jun 10, 2021

@RudiThoeni @sseppi FYI

@Piiit
Copy link
Contributor Author

Piiit commented Jun 10, 2021

What should we do with closed data on tourism? Should we expose that data on our /restricted VKG?

@bcogrel
Copy link
Collaborator

bcogrel commented Jun 14, 2021

Hi, thanks for the update, that's an interesting move.

At the moment closed data on tourism is not mapped. Making it available to /restricted would be a new feature.

@Piiit , could you please send us a new dump of the database? Non-"open" tables are empty in our local test image. Ideally, it would great for us to have also closed data. We would then exclude them from the public Docker database image, while keeping it in our private one, as we did for mobility data.

Benjamin

@Piiit
Copy link
Contributor Author

Piiit commented Jun 23, 2022

@bcogrel @jcte02
We updated the CD pipelines to automatically deploy the new VKG with Postgres virtual-knowledge-graph.co90ybcr8iim.eu-west-1.rds.amazonaws.com/vkg, but I get an error:

Error: Unable to find attribute "AccoDetail-de-Email"

ontop-guest_1  | Error starting ApplicationContext. To display the conditions report re-run your application with 'debug' enabled.
ontop-guest_1  | 09:40:16.461 |-ERROR in o.s.boot.SpringApplication - Application run failed
ontop-guest_1  | org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'sparqlQueryController' defined in URL [jar:file:/opt/ontop/lib/ontop-endpoint-4.2.0.jar!/it/unibz/inf/ontop/endpoint/controllers/SparqlQueryController.class]: Unsatisfied dependency expressed through constructor parameter 0; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'setupVirtualRepository' defined in class path resource [it/unibz/inf/ontop/endpoint/beans/OntopVirtualRepositoryBean.class]: Bean instantiation via factory method failed; nested exception is org.springframework.beans.BeanInstantiationException: Failed to instantiate [it.unibz.inf.ontop.rdf4j.repository.impl.OntopVirtualRepository]: Factory method 'setupVirtualRepository' threw exception; nested exception is org.eclipse.rdf4j.repository.RepositoryException: it.unibz.inf.ontop.exception.InvalidMappingSourceQueriesException: Error: Unable to find attribute "AccoDetail-de-Email" (available attributes are ["Id",

.......

I think we might need to update some mappings...

If we need to update triggers or table definitions we need to setup flyway again. Otherwise we are never sure which exact schema version is installed.

@bcogrel
Copy link
Collaborator

bcogrel commented Jun 24, 2022

@Piiit , I have prepared a PR for this: #59

Some the changes it brings to the mapping are temporary, and will need to be reverted once Flyway will have been run over the new database.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants