Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helper block edit dialogues open an all click events, even move and delete #132

Open
yogo1212 opened this issue Aug 7, 2022 · 5 comments

Comments

@yogo1212
Copy link

yogo1212 commented Aug 7, 2022

when i delete a custom block, an editor pops up

@nomeata
Copy link
Owner

nomeata commented Aug 8, 2022

Hmm, I tried to reproduce it, but couldn’t. Can you give step-for-step instructions, or post a screen capture video?

@michaelgwelch
Copy link
Contributor

michaelgwelch commented Aug 8, 2022

I've seen this with "type annotation" helper block which is maybe what is being referred to.

output.mp4

The editor pops up on a move or delete.

@nomeata nomeata changed the title custom block editor opens on deletion Helper block edit dialogues open an all click events, even move and delete Aug 8, 2022
@nomeata
Copy link
Owner

nomeata commented Aug 8, 2022

Thanks! That clarifies things.

As you can see in your recording, it even happens when moving the block.

It looks like the on-click-handling, which opens the dialogue, started to act even when something else happened (moving, deletion). I wonder if this is due to a recent in one of the used libraries.

It doesn’t seem to be too disastrous, so I’ll have a look when I am touching the code anyways. But if someone else wants to give it a shot: It’s plain JavaScript, and I guess the bug is somewhere here: https://github.com/nomeata/incredible/tree/master/webui

@michaelgwelch
Copy link
Contributor

As you can see in your recording, it even happens when moving the block.

Yeah, i mentioned that, but my comment was under the video and easily missed.

@yogo1212
Copy link
Author

yogo1212 commented Aug 9, 2022

oops! i only played with it a bit and found the bug - sorry for the confusion!
and thanks, @michaelgwelch for adding the correction :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants