Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create transactions #26

Open
ekoskent opened this issue Jan 28, 2020 · 11 comments
Open

Create transactions #26

ekoskent opened this issue Jan 28, 2020 · 11 comments

Comments

@ekoskent
Copy link

As a: business owner / user of a business system
I wish to: create accounting entries (business transactions) in another system outside the actual accounting system and record them in the accounting system.

@ekoskent
Copy link
Author

For instance POS systems transfer the accounting entries generated from sales at the end of business day directly as accounting entries including already the account details etc (not by using indivudual sales receipts as vouchers although this is also possible)

@ekoskent
Copy link
Author

ekoskent commented Jan 28, 2020

We should create add to the transaction API "Create transaction" (similar than the update transaction). Once the transactions are posted to the system (as xbrl gl) the internal transaction ID should be assigned to them. Should we require that some voucher(pdf) should be posted in the system before the transactions may be created (would it violate the data base logic if there would be no voucher/business document)?

@frodegill
Copy link

FWIW, you should now be able to upload an XBRL GL document (to /document/{companyId}) and have a transaction created for it.

@ekoskent
Copy link
Author

ekoskent commented Mar 5, 2020

FWIW, you should now be able to upload an XBRL GL document (to /document/{companyId}) and have a transaction created for it.

Should it not be by the transaction API (not document) to create a new transaction by posting XBRL GL data?

@frodegill
Copy link

No? You post a document (which happens to be an XBRL GL document).

@ekoskent
Copy link
Author

ekoskent commented Mar 6, 2020

No? You post a document (which happens to be an XBRL GL document).

Aa ok, so the XBRL GL data then becomes the voucher document as well? This is ok, but I am able to use the "regular" business document formats still? There was some issues when I tried to add a UBL invoice as a new doc.

@frodegill
Copy link

The XBRL GL document will be the one document that creates the transaction, but it will not be split up and/or parsed. Just remember to use correct(/matching) mime-types

@ekoskent
Copy link
Author

ekoskent commented Mar 9, 2020

The XBRL GL document will be the one document that creates the transaction, but it will not be split up and/or parsed. Just remember to use correct(/matching) mime-types

Will do. Speaking of which, should the options be listed also in the API .yaml definitions? I noticed that the response notification from the bad request was not always matching to what the yaml file was saying and also in the notification there was some issue with the provided mime type list, the quote marks were in the correct place etc..

@frodegill
Copy link

There are two places where I have to specify "/" as mime-type in the OpenAPI spec, but the code implementing it generates a list of valid(/expected) mime-types. I've tried to get this into Swagger, but so far failed. Are there any other issues you feel is present? Quote marks in incorrect place, I presume? Do you have a screenshot or a way for me to recreate it?

@ekoskent
Copy link
Author

ekoskent commented Mar 10, 2020 via email

@ekoskent
Copy link
Author

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants