Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension stopped working #3

Closed
uyitroa opened this issue Apr 19, 2024 · 3 comments · Fixed by #4
Closed

Extension stopped working #3

uyitroa opened this issue Apr 19, 2024 · 3 comments · Fixed by #4

Comments

@uyitroa
Copy link
Contributor

uyitroa commented Apr 19, 2024

Issue description

This extension had been working for a few months now, but I noticed that it just stopped working today. I'm using Safari 16.3, macOS 13.2. It doesn't mute nor speeding up ad anymore.

@uyitroa
Copy link
Contributor Author

uyitroa commented Apr 19, 2024

After checking, I believe that

var adOverlay = document.querySelector('.ytp-ad-player-overlay');

is null even though there is an ad in the video.

However, I noticed that .ytp-ad-player-overlay-layout is not null so maybe we could change the line to

var adOverlay = document.querySelector('.ytp-ad-player-overlay-layout');

@WeiChihChern
Copy link

Yeah, I think youtube has changed something that makes the extension fails.

Have you tried your modification and see if it works?

@notarisj
Copy link
Owner

I just noticed this issue today. I will be testing it, and if it does not cover all cases, I will try to fix it with a wildcard to be less prone to YouTube changes and create a new release. Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants