Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wall corners from secret areas render in some cases, giving away their location #677

Open
al0fdf opened this issue Feb 12, 2024 · 3 comments
Labels
A: Video 🎥 Game rendering and movies S: Vanilla A bug which was present in vanilla game as well T: Bug 🐛 Something isn't working

Comments

@al0fdf
Copy link
Contributor

al0fdf commented Feb 12, 2024

In Field of Valor, the walls near this secret area for some reason render, even though they shouldn't. This is present in the original game also:
image

image

@dennwc dennwc added T: Bug 🐛 Something isn't working A: Video 🎥 Game rendering and movies S: Vanilla A bug which was present in vanilla game as well labels Feb 12, 2024
@KILAH4716
Copy link

Unfortunately this is a map development issue.

The layout of walls are all at the corners of a grid, and determine how the wall intersects at the corner. So if we see that wall configuration, we see the complete configuration on our minimap. This'll be a difficult fix.

image

@dennwc
Copy link
Collaborator

dennwc commented Feb 16, 2024

I wonder if we can make it draw L shape instead of X shape if part of it is not visible 🤔

I didn't look yet how the walls are store in the map and if the all have same codes for X shapes, for example. If not, that would be harder.

@albertdev
Copy link

Interesting, I never noticed those corners also were visible in the world. I always used the minimap to hunt for secrets.

Is it really something that needs changing though? One still needs to pay attention to find them all, so why make it harder?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Video 🎥 Game rendering and movies S: Vanilla A bug which was present in vanilla game as well T: Bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants