Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kibana version 6.0 #79

Open
byn017 opened this issue Nov 20, 2017 · 15 comments
Open

Kibana version 6.0 #79

byn017 opened this issue Nov 20, 2017 · 15 comments

Comments

@byn017
Copy link

byn017 commented Nov 20, 2017

Hi,

The plugin doesn't work with kibana version 6.0.
Does the plugin going to support version 6.0?

Thanks

@nreese
Copy link
Owner

nreese commented Nov 20, 2017

The current plugin does not currently support 6.0.

@byn017
Copy link
Author

byn017 commented Nov 20, 2017

Is it going to support version 6.0? If yes when do you think it will be ready?

Thanks in advance

@nreese
Copy link
Owner

nreese commented Nov 20, 2017

It may eventually but not a huge priority so I would not expect it any time in the next three months.

@Shifter2600
Copy link

Thx for the update @nreese

@spreeker
Copy link

spreeker commented Jan 10, 2018

Are the changes big?

@Pilarbr82
Copy link

Hi!!!!

I would like to use the plugin. When do you think it would be ready??

Thanks a lot

@nreese
Copy link
Owner

nreese commented Jan 23, 2018

I have not been able to look into updating the plugin to 6.0. I have no estimation on when the plugin will get updated. Pull requests are welcome

@Pilarbr82
Copy link

Ok, thank you for your quickly answer

@pranshu1995
Copy link

Hey @nreese Is the plugin compatible for Kibana 6 now?

@nreese
Copy link
Owner

nreese commented Mar 12, 2018

no

@alexandrejuma
Copy link

Would be great to have the plugin working for Kibana 6.

@pranshu1995
Copy link

Hey All

I've tried to migrate the plugin to Kibana v6.1.2.
But I am facing some issues.
The visualisation is loading without any errors.
But the problem is that data is not being plotted on the map.
I checked the query being sent in Dev-Tools and the data fetched is fine.
Here is my fork : https://github.com/pranshu1995/enhanced_tilemap

Any help would be appreciated.
Thank you

@swathigorijala
Copy link

It would be better if have this plugin for 6+

@cspielmann
Copy link

this plugin is so good in 5.X.
I am eager to get it for 6.X as I just migrated....

@JacobBrandt
Copy link
Collaborator

Unfortunately, you probably won't see this plugin work again for newer versions without getting your hands dirty and figuring out all the Kibana API changes made between 5 and 6. Fair warning, if you haven't been doing Kibana development at all then it's a lot to wrap your head around. The Kibana team has even completely removed functionality that this plugin was dependent on in versions of 6 which means you'll have to rework some of the code for certain features to work.

If you want this plugin to work then you'll most likely have to get your hands dirty in which I have this to say...write a new plugin or rewrite the plugin. If you plan to be brave and work on a kibana plugin then keep these things in mind.

  • Don't have any code outside of the controller/provider that is directly dependent on Kibana.
  • Don't have any code be dependent on how Kibana parses the ES response. Come up with your own data structure and pass it along.
  • Keep your Kibana dependent code to a minimum.

I realize that all three of these in a way are related and that's the point. It's very important to keep your plugin isolated from the Kibana code as it's too volatile.

If you do these three things then upgrading will be a heck of a lot easier and all your upgrade changes to new versions will be isolated to the two files that are dependent on the Kibana API and it's services (courier, app state, indexPatterns, etc.). Once you resolve the Kibana dependency issues in your controller and provider than you'll know everything else will just work as it's just your own code from before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants