-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make client requests non blocking #24
Comments
Somewhat related: why do we send a request to the client in order to get the IP? Why not simply save the IP in the database when the client registers to the server? Sounds like it would be a lot simpler, no? And if the IP changes, the client would anyway register again to the server I suppose, since changing IP address (almost always) implies we lost network connectivity. Or am I missing something? |
Ok. Checkout #29 |
Okay. I don't have the competence to judge by just looking at it if that makes sense. I trust you to keep testing until you're confident it can be merged. |
Another thing (no need to respond, just for documentation). |
autopower/client/client.cc
Line 631 in 1911af7
is executed in one thread only. To allow responsiveness, we should rewrite the code such that we execute management functionality in a separate/separate threads. Then the client remains responsive for new commands from the server and can already start them if possible. This could fix #23 potentially.
Suggestion:
The text was updated successfully, but these errors were encountered: