Support for WHFB 8th/6th Edition Support

[Robbie558]

WHFB 8th edition is currently disabled on the live web-app. Can I ask why that is the case?

I have a rough PoC working on my end to support WHFB 6th edition as well as 8th edition.

PS - Thanks so much for developing the application! I use it extensively for ToW list and can't recommend it enough

[nthiebes]

The app needs some adjustments to again work with WHFB, and I was focussing on ToW for now. There are still a few things I want to do before putting any work into WHFB, which was barely used before ToW.

A lot of effort will also be adding all factions, I only created datasets for 3 factions and they require some updates. If you already have something prepared, I'd love to see it! 🙌

[Robbie558]

I'll fork your repo and push changes this week, will ping a link when it's done.

[Robbie558]

Sorry for the delay, but I have forked your repository and committed my changes - https://github.com/Robbie558/old-world-builder. This is my first time working with React so please be kind 🙏🏻

I cannot generate a list for either 8th or 6th edition using the 8th edition lists, and I just get the spinner when reaching the editor/<list_slug>/add/lords endpoint. I cant get this to work on your main branch either (i have just un-commented this line on [NewList.js](https://github.com/nthiebes/old-world-builder/blob/main/src/pages/new-list/NewList.js#L144 to re-enable WHFB lists) and cant see any obvious issues here.

Happy to spend the time building some test lists for 6th edition to get a full PoC.

[Robbie558]

I can see the issue now with the assignment to getArmyData in Add.js, 🫤

[Robbie558]

Above issues have been resolved and I am able to create lists. I have created an initial JSON army lists for O&G to verify ability to build lists. Currently working on splitting out ToW / WHFB calls to whfb.app for rules and stats retrieval.

Merged your changes up to release v1.7.3

[nthiebes]

Hey man, that sounds great! If you have something to already check in a draft PR let me know 👍. I hope that re-adding support for other editions doesn't make the app too complex. I also have a few ideas how to optimize the datasets to make it easier adding new ones. It probably makes sense to talk about them before adding new systems.

[Robbie558]

Hey there! Nothing too complex, but there is probably better ways to do what I have implemented. I am familiar with NodeJS, but this is my first time developing in a React app, and I am using this as an opportunity to learn as I go.

Yes the worst part is managing the datasets 😭 Its a bit confusing switching between the army lists and the rules maps , trying to work out where the rule links are defined.

I have a forked copy of your repo, and am committing direct to main branch fairly frequently - https://github.com/Robbie558/old-world-builder. Let us know what you think