Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Make jump_target a property of SCFG #73

Open
Tracked by #72
kc611 opened this issue Jun 19, 2023 · 2 comments · May be fixed by #83 or #58
Open
Tracked by #72

Refactor: Make jump_target a property of SCFG #73

kc611 opened this issue Jun 19, 2023 · 2 comments · May be fixed by #83 or #58

Comments

@kc611
Copy link
Contributor

kc611 commented Jun 19, 2023

The attribute jump_target of BasicBlock class is mutated over the course of various transformations, this leads to the blocks being rebuilt and the SCFG being deep copied every time a transformation is applied.

It should be made a mutable property of the SCFG class instead of an immutable property of the BasicBlock frozen data class. This will prevent unnecessary copies.
@kc611 kc611 mentioned this issue Jun 19, 2023
Closed
6 tasks
@guilhermeleobas
Copy link
Contributor

guilhermeleobas commented Jul 4, 2023 •
edited
Loading

Hi @kc611, is this somehow related to #58? Or this issue is open for someone to work on?

@kc611
Copy link
Contributor Author

kc611 commented Jul 7, 2023

Yes, it is what #58 was made to resolve. I'll link the issue shortly.

This was referenced Jun 30, 2023
Draft
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@guilhermeleobas @kc611