Use specific constraint #839
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NUnitFrameworkConstants NUnitLegacyFrameworkConstants NUnitV4FrameworkConstants Main reason was for V4 as this can only be tested when compiling against V4
This is for: Is.EqualTo(false) => Is.False Is.EqualTo(true) => Is.True Is.EqualTo(null) => Is.Null Is.EqualTo(default) => Is.Default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #824
Fixes #826
Fixes #828
@mikkelbu The first commit is not directly related but was necessary to allow NUnit 4 specific names to be only tested when building against NUnit instead of making up the names in the analyzer code.
The second commit add the new analyzer and code fix.
There was a small change in the documentation tests as they were not testing for the new Style analyzers.
If you think this analyzer should be in a different category, that is fine by me.