Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle var, let, and const #124

Open
mwaldrich opened this issue Sep 3, 2020 · 0 comments
Open

Correctly handle var, let, and const #124

mwaldrich opened this issue Sep 3, 2020 · 0 comments

Comments

@mwaldrich
Copy link
Member

Currently, all 3 ways of declaring a variable are handled like var inside jankscripten. This stemmed from a parser bug in the old parser, and I had to replicate the bug in the new parser in order to get the tests to pass.

I'm not sure if we already decided to support let or const, but I don't think there's any machinery implemented for them already. We might be able to get away with treating const like var. let might be trickier to ignore, since it has different scoping rules than var, which some of our programs may rely on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant