Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tabular_classification/PassiveAClf.py no predict_proba function #128

Open
delphieritas opened this issue Aug 20, 2020 · 2 comments
Open

Comments

@delphieritas
Copy link
Contributor

    # probs = self._clf.predict_proba(data) 
    # PassiveAggressiveClassifier does not have predict_proba function, we can use _predict_proba_lr() function,
    # pls see https://github.com/scikit-learn/scikit-learn/blob/0fb307bf3/sklearn/linear_model/_base.py#L261

pls merge dev...delphieritas:patch-3

@delphieritas
Copy link
Contributor Author

delphieritas commented Aug 20, 2020

To justify the input format changes:

When do prepare_X(queries), it was supposed to be pandas Dataframe. But the original input passes a list to that function, then it won't work

@pinpom
Copy link
Contributor

pinpom commented Aug 20, 2020

@delphieritas: as discussed, please run those models on singa-auto system to see if there is any errors and start from there. I did run those models successfully on singa-auto before, but there have been quite some changes on the system, i.e. data format,... so need to check and update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants