Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search should put the registry data at the end of the table #96

Open
KAAtheWiseGit opened this issue Jul 22, 2024 · 2 comments
Open

Search should put the registry data at the end of the table #96

KAAtheWiseGit opened this issue Jul 22, 2024 · 2 comments

Comments

@KAAtheWiseGit
Copy link

Currently, registry_name and registry_path are at the start of the table returned by nupm search. I think that this information is repetitive and not as important, as version and type. But, due to the long registry path, it registry info pushes out everything else:

~/fork/nupm/nupm> nupm search plugin
─────┬────────────────┬──────────────────────────────────────────────────────────┬─────
   # │ registry_name  │                      registry_path                       │ ... 
─────┼────────────────┼──────────────────────────────────────────────────────────┼─────
   0  nupm_test       /home/kaathewise/.config/nushell/nupm/cache/registry/nup  ... 
                      m_test.nuon                                                   
   1  nupm_test       /home/kaathewise/.config/nushell/nupm/cache/registry/nup  ... 
                      m_test.nuon                                                   
   2  nupm_test       /home/kaathewise/.config/nushell/nupm/cache/registry/nup  ... 
                      m_test.nuon                                                   
   3  nupm_test       /home/kaathewise/.config/nushell/nupm/cache/registry/nup  ... 
                      m_test.nuon                                                   
   4  nupm_test       /home/kaathewise/.config/nushell/nupm/cache/registry/nup  ... 
                      m_test.nuon                                                   

So, I want to suggest putting these two columns at the end:

~/fork/nupm> nupm search git
─────┬───────────────────────┬─────────┬───────────────────────────┬──────┬──────┬─────
   # │         name          │ version │           path            │ type │ info │ ... 
─────┼───────────────────────┼─────────┼───────────────────────────┼──────┼──────┼─────
   0  nu-git-manager         0.1.0    pkgs/nu-git-manager        git   {rec  ... 
                                                                       ord       
                                                                       2 fi      
                                                                       elds      
                                                                       }         
   1  nu-git-manager-sugar   0.1.0    pkgs/nu-git-manager-sugar  git   {rec  ... 
                                                                       ord       
                                                                       2 fi      
                                                                       elds      
                                                                       }         
   2  nu-git-manager         0.2.0    pkgs/nu-git-manager        git   {rec  ... 
                                                                       ord       
                                                                       2 fi      
                                                                       elds      
                                                                       }         
...
@KAAtheWiseGit
Copy link
Author

It's a minor, but stylistic change, so I wanted to open an issue before making a PR

@amtoine
Copy link
Member

amtoine commented Jul 26, 2024

that sounds reasonable to me!

i tend to put paths or URLs at the right of tables too 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants