From ed05d8ae01915c721fc97d6fb70d0763836b41c9 Mon Sep 17 00:00:00 2001 From: rahuljain-dev Date: Mon, 15 Jan 2024 12:32:42 +0530 Subject: [PATCH] fix a11y --- .github/workflows/a11y.yaml | 2 +- .github/workflows/catalog.yaml | 3 --- .github/workflows/cross-repo.yaml | 12 ++++-------- .github/workflows/main.yaml | 19 ++++++++++--------- .github/workflows/veracode.yml | 3 +-- .../app/nuxeo/rest/directory.js | 2 +- .../nuxeo-spreadsheet/app/nuxeo/rest/query.js | 2 +- .../app/nuxeo/rest/request.js | 2 +- .../app/nuxeo/rpc/directory.js | 2 +- .../app/nuxeo/rpc/operation.js | 2 +- .../nuxeo-spreadsheet/app/nuxeo/rpc/query.js | 2 +- addons/nuxeo-spreadsheet/app/nuxeo/widget.js | 2 +- addons/nuxeo-spreadsheet/app/ui/column.js | 2 +- .../app/ui/editors/directory.js | 2 +- .../app/ui/editors/document.js | 2 +- .../nuxeo-spreadsheet/app/ui/editors/image.js | 2 +- .../app/ui/editors/select2.js | 2 +- .../nuxeo-spreadsheet/app/ui/editors/user.js | 2 +- addons/nuxeo-spreadsheet/app/ui/log.js | 2 +- .../nuxeo-spreadsheet/app/ui/spreadsheet.js | 2 +- addons/nuxeo-spreadsheet/app/ui/widgets.js | 2 +- test/nuxeo-picture-formats.test.js | 19 ------------------- 22 files changed, 32 insertions(+), 58 deletions(-) diff --git a/.github/workflows/a11y.yaml b/.github/workflows/a11y.yaml index a9c8698f8d..7af3a855a7 100644 --- a/.github/workflows/a11y.yaml +++ b/.github/workflows/a11y.yaml @@ -35,7 +35,7 @@ jobs: with: ref: ${{ env.BRANCH_NAME }} - - run: git config user.name "nuxeo-webui-jx-bot" && git config user.email "webui@hyland.com" + - run: git config user.name "nuxeo-webui-jx-bot" && git config user.email "webui@hyland.com" - uses: actions/setup-node@v3 with: diff --git a/.github/workflows/catalog.yaml b/.github/workflows/catalog.yaml index a9273f09ab..ac4108bd55 100644 --- a/.github/workflows/catalog.yaml +++ b/.github/workflows/catalog.yaml @@ -79,9 +79,6 @@ jobs: - name: Install libxml2-utils (xmllint) run: sudo apt-get update && sudo apt-get install -y libxml2-utils - - name: Install libxml2-utils (xmllint) - run: sudo apt-get update && sudo apt-get install -y libxml2-utils - - name: Setup parameters (release) if: github.event_name == 'release' working-directory: packages/nuxeo-designer-catalog diff --git a/.github/workflows/cross-repo.yaml b/.github/workflows/cross-repo.yaml index d76c57c44a..85302b1ba5 100644 --- a/.github/workflows/cross-repo.yaml +++ b/.github/workflows/cross-repo.yaml @@ -192,14 +192,10 @@ jobs: fi mvn install -ntp $active_profiles -DskipInstall - #================================================================================================================== - # this line of code has been commented on due to some driver issues, we will resume it once WEBUI-1266 is resolved. - #================================================================================================================== - # - name: A11y checks - # if: ${{ github.event.inputs.skip_a11y == 'false' }} - # run: | - # mvn -B -nsu -f plugin/a11y -ntp install - #================================================================================================================== + - name: A11y checks + if: ${{ github.event.inputs.skip_a11y == 'false' }} + run: | + mvn -B -nsu -f plugin/a11y -ntp install - name: Archive cucumber reports if: ${{ always() }} diff --git a/.github/workflows/main.yaml b/.github/workflows/main.yaml index 44946dc45f..287655494c 100644 --- a/.github/workflows/main.yaml +++ b/.github/workflows/main.yaml @@ -63,11 +63,6 @@ jobs: echo "BRANCH_NAME=${GITHUB_HEAD_REF##*/}" >> $GITHUB_ENV echo "PACKAGE_VERSION=$(npx -c 'echo "$npm_package_version"')" >> $GITHUB_ENV - - name: Prepare environment - run: | - echo "BRANCH_NAME=${GITHUB_HEAD_REF##*/}" >> $GITHUB_ENV - echo "PACKAGE_VERSION=$(npx -c 'echo "$npm_package_version"')" >> $GITHUB_ENV - - name: Get prerelease version run: | git fetch origin --tags @@ -107,11 +102,17 @@ jobs: mvn -B -nsu -ntp -f plugin/itests/addon install mvn -B -nsu -ntp -f plugin/itests/marketplace install - - name: Nuxeo package build + - name: 'Update settings.xml with server configuration' run: | - mvn -ntp install -DskipInstall - mvn -B -nsu -ntp -f plugin/itests/addon install - mvn -B -nsu -ntp -f plugin/itests/marketplace install + echo ' + + + maven-internal + ${{ secrets.PACKAGES_AUTH_USER }} + ${{ secrets.PACKAGES_AUTH_TOKEN }} + + + ' > ~/.m2/settings.xml - name: Archive packages uses: actions/upload-artifact@v2 diff --git a/.github/workflows/veracode.yml b/.github/workflows/veracode.yml index 27a67de637..149fbf4f9f 100644 --- a/.github/workflows/veracode.yml +++ b/.github/workflows/veracode.yml @@ -190,5 +190,4 @@ jobs: with: token: ${{ secrets.SLACK_BOT_TOKEN }} path: results.txt - channel: ${{ secrets.SLACK_CHANNEL_ID }} - + channel: ${{ secrets.SLACK_CHANNEL_ID }} \ No newline at end of file diff --git a/addons/nuxeo-spreadsheet/app/nuxeo/rest/directory.js b/addons/nuxeo-spreadsheet/app/nuxeo/rest/directory.js index a5aa78d686..348bb63e78 100644 --- a/addons/nuxeo-spreadsheet/app/nuxeo/rest/directory.js +++ b/addons/nuxeo-spreadsheet/app/nuxeo/rest/directory.js @@ -1,5 +1,5 @@ /* - * ©2023 Hyland Software, Inc. and its affiliates. All rights reserved. + *©2023 Hyland Software, Inc. and its affiliates. All rights reserved. All Hyland product names are registered or unregistered trademarks of Hyland Software, Inc. or its affiliates. * * All rights reserved. This program and the accompanying materials diff --git a/addons/nuxeo-spreadsheet/app/nuxeo/rest/query.js b/addons/nuxeo-spreadsheet/app/nuxeo/rest/query.js index c8a811a8fb..530ab9a8dd 100644 --- a/addons/nuxeo-spreadsheet/app/nuxeo/rest/query.js +++ b/addons/nuxeo-spreadsheet/app/nuxeo/rest/query.js @@ -1,5 +1,5 @@ /* - * ©2023 Hyland Software, Inc. and its affiliates. All rights reserved. + *©2023 Hyland Software, Inc. and its affiliates. All rights reserved. All Hyland product names are registered or unregistered trademarks of Hyland Software, Inc. or its affiliates. * * All rights reserved. This program and the accompanying materials diff --git a/addons/nuxeo-spreadsheet/app/nuxeo/rest/request.js b/addons/nuxeo-spreadsheet/app/nuxeo/rest/request.js index d76ad90cd1..db34fbd2b1 100644 --- a/addons/nuxeo-spreadsheet/app/nuxeo/rest/request.js +++ b/addons/nuxeo-spreadsheet/app/nuxeo/rest/request.js @@ -1,5 +1,5 @@ /* - * ©2023 Hyland Software, Inc. and its affiliates. All rights reserved. + *©2023 Hyland Software, Inc. and its affiliates. All rights reserved. All Hyland product names are registered or unregistered trademarks of Hyland Software, Inc. or its affiliates. * * All rights reserved. This program and the accompanying materials diff --git a/addons/nuxeo-spreadsheet/app/nuxeo/rpc/directory.js b/addons/nuxeo-spreadsheet/app/nuxeo/rpc/directory.js index 37b50ba79f..e845df2b97 100644 --- a/addons/nuxeo-spreadsheet/app/nuxeo/rpc/directory.js +++ b/addons/nuxeo-spreadsheet/app/nuxeo/rpc/directory.js @@ -1,5 +1,5 @@ /* - * ©2023 Hyland Software, Inc. and its affiliates. All rights reserved. + *©2023 Hyland Software, Inc. and its affiliates. All rights reserved. All Hyland product names are registered or unregistered trademarks of Hyland Software, Inc. or its affiliates. * * All rights reserved. This program and the accompanying materials diff --git a/addons/nuxeo-spreadsheet/app/nuxeo/rpc/operation.js b/addons/nuxeo-spreadsheet/app/nuxeo/rpc/operation.js index 005c067905..ab7e5d5399 100644 --- a/addons/nuxeo-spreadsheet/app/nuxeo/rpc/operation.js +++ b/addons/nuxeo-spreadsheet/app/nuxeo/rpc/operation.js @@ -1,5 +1,5 @@ /* - * ©2023 Hyland Software, Inc. and its affiliates. All rights reserved. + *©2023 Hyland Software, Inc. and its affiliates. All rights reserved. All Hyland product names are registered or unregistered trademarks of Hyland Software, Inc. or its affiliates. * * All rights reserved. This program and the accompanying materials diff --git a/addons/nuxeo-spreadsheet/app/nuxeo/rpc/query.js b/addons/nuxeo-spreadsheet/app/nuxeo/rpc/query.js index 2353585b97..7a277b896d 100644 --- a/addons/nuxeo-spreadsheet/app/nuxeo/rpc/query.js +++ b/addons/nuxeo-spreadsheet/app/nuxeo/rpc/query.js @@ -1,5 +1,5 @@ /* - * ©2023 Hyland Software, Inc. and its affiliates. All rights reserved. + *©2023 Hyland Software, Inc. and its affiliates. All rights reserved. All Hyland product names are registered or unregistered trademarks of Hyland Software, Inc. or its affiliates. * * All rights reserved. This program and the accompanying materials diff --git a/addons/nuxeo-spreadsheet/app/nuxeo/widget.js b/addons/nuxeo-spreadsheet/app/nuxeo/widget.js index ca396745be..372ec8a870 100644 --- a/addons/nuxeo-spreadsheet/app/nuxeo/widget.js +++ b/addons/nuxeo-spreadsheet/app/nuxeo/widget.js @@ -1,5 +1,5 @@ /* - * ©2023 Hyland Software, Inc. and its affiliates. All rights reserved. + *©2023 Hyland Software, Inc. and its affiliates. All rights reserved. All Hyland product names are registered or unregistered trademarks of Hyland Software, Inc. or its affiliates. * * All rights reserved. This program and the accompanying materials diff --git a/addons/nuxeo-spreadsheet/app/ui/column.js b/addons/nuxeo-spreadsheet/app/ui/column.js index cc75acce7f..64ccf83f11 100644 --- a/addons/nuxeo-spreadsheet/app/ui/column.js +++ b/addons/nuxeo-spreadsheet/app/ui/column.js @@ -1,5 +1,5 @@ /* - * ©2023 Hyland Software, Inc. and its affiliates. All rights reserved. + *©2023 Hyland Software, Inc. and its affiliates. All rights reserved. All Hyland product names are registered or unregistered trademarks of Hyland Software, Inc. or its affiliates. * * All rights reserved. This program and the accompanying materials diff --git a/addons/nuxeo-spreadsheet/app/ui/editors/directory.js b/addons/nuxeo-spreadsheet/app/ui/editors/directory.js index 7664b26851..53f0c4de23 100644 --- a/addons/nuxeo-spreadsheet/app/ui/editors/directory.js +++ b/addons/nuxeo-spreadsheet/app/ui/editors/directory.js @@ -1,5 +1,5 @@ /* - * ©2023 Hyland Software, Inc. and its affiliates. All rights reserved. + *©2023 Hyland Software, Inc. and its affiliates. All rights reserved. All Hyland product names are registered or unregistered trademarks of Hyland Software, Inc. or its affiliates. * * All rights reserved. This program and the accompanying materials diff --git a/addons/nuxeo-spreadsheet/app/ui/editors/document.js b/addons/nuxeo-spreadsheet/app/ui/editors/document.js index 8a018fce1e..0a0841bce4 100644 --- a/addons/nuxeo-spreadsheet/app/ui/editors/document.js +++ b/addons/nuxeo-spreadsheet/app/ui/editors/document.js @@ -1,5 +1,5 @@ /* - * ©2023 Hyland Software, Inc. and its affiliates. All rights reserved. + *©2023 Hyland Software, Inc. and its affiliates. All rights reserved. All Hyland product names are registered or unregistered trademarks of Hyland Software, Inc. or its affiliates. * * All rights reserved. This program and the accompanying materials diff --git a/addons/nuxeo-spreadsheet/app/ui/editors/image.js b/addons/nuxeo-spreadsheet/app/ui/editors/image.js index 4c7cb21cb4..9b47ccf5e4 100644 --- a/addons/nuxeo-spreadsheet/app/ui/editors/image.js +++ b/addons/nuxeo-spreadsheet/app/ui/editors/image.js @@ -1,5 +1,5 @@ /* - * ©2023 Hyland Software, Inc. and its affiliates. All rights reserved. + *©2023 Hyland Software, Inc. and its affiliates. All rights reserved. All Hyland product names are registered or unregistered trademarks of Hyland Software, Inc. or its affiliates. * * All rights reserved. This program and the accompanying materials diff --git a/addons/nuxeo-spreadsheet/app/ui/editors/select2.js b/addons/nuxeo-spreadsheet/app/ui/editors/select2.js index 62483134e2..ca97d488d3 100644 --- a/addons/nuxeo-spreadsheet/app/ui/editors/select2.js +++ b/addons/nuxeo-spreadsheet/app/ui/editors/select2.js @@ -1,5 +1,5 @@ /* - * ©2023 Hyland Software, Inc. and its affiliates. All rights reserved. + *©2023 Hyland Software, Inc. and its affiliates. All rights reserved. All Hyland product names are registered or unregistered trademarks of Hyland Software, Inc. or its affiliates. * * All rights reserved. This program and the accompanying materials diff --git a/addons/nuxeo-spreadsheet/app/ui/editors/user.js b/addons/nuxeo-spreadsheet/app/ui/editors/user.js index 4f53be2a56..1df0434325 100644 --- a/addons/nuxeo-spreadsheet/app/ui/editors/user.js +++ b/addons/nuxeo-spreadsheet/app/ui/editors/user.js @@ -1,5 +1,5 @@ /* - * ©2023 Hyland Software, Inc. and its affiliates. All rights reserved. + *©2023 Hyland Software, Inc. and its affiliates. All rights reserved. All Hyland product names are registered or unregistered trademarks of Hyland Software, Inc. or its affiliates. * * All rights reserved. This program and the accompanying materials diff --git a/addons/nuxeo-spreadsheet/app/ui/log.js b/addons/nuxeo-spreadsheet/app/ui/log.js index f7a1c911bb..904edd5311 100644 --- a/addons/nuxeo-spreadsheet/app/ui/log.js +++ b/addons/nuxeo-spreadsheet/app/ui/log.js @@ -1,5 +1,5 @@ /* - * ©2023 Hyland Software, Inc. and its affiliates. All rights reserved. + *©2023 Hyland Software, Inc. and its affiliates. All rights reserved. All Hyland product names are registered or unregistered trademarks of Hyland Software, Inc. or its affiliates. * * All rights reserved. This program and the accompanying materials diff --git a/addons/nuxeo-spreadsheet/app/ui/spreadsheet.js b/addons/nuxeo-spreadsheet/app/ui/spreadsheet.js index 2bcaa4bdec..9f1f2c61b3 100644 --- a/addons/nuxeo-spreadsheet/app/ui/spreadsheet.js +++ b/addons/nuxeo-spreadsheet/app/ui/spreadsheet.js @@ -1,5 +1,5 @@ /* - * ©2023 Hyland Software, Inc. and its affiliates. All rights reserved. + *©2023 Hyland Software, Inc. and its affiliates. All rights reserved. All Hyland product names are registered or unregistered trademarks of Hyland Software, Inc. or its affiliates. * * All rights reserved. This program and the accompanying materials diff --git a/addons/nuxeo-spreadsheet/app/ui/widgets.js b/addons/nuxeo-spreadsheet/app/ui/widgets.js index b51a020bed..6fab91de50 100644 --- a/addons/nuxeo-spreadsheet/app/ui/widgets.js +++ b/addons/nuxeo-spreadsheet/app/ui/widgets.js @@ -1,5 +1,5 @@ /* - * ©2023 Hyland Software, Inc. and its affiliates. All rights reserved. + *©2023 Hyland Software, Inc. and its affiliates. All rights reserved. All Hyland product names are registered or unregistered trademarks of Hyland Software, Inc. or its affiliates. * * All rights reserved. This program and the accompanying materials diff --git a/test/nuxeo-picture-formats.test.js b/test/nuxeo-picture-formats.test.js index 27d7a2d37e..7c8cda5081 100644 --- a/test/nuxeo-picture-formats.test.js +++ b/test/nuxeo-picture-formats.test.js @@ -97,23 +97,4 @@ suite('nuxeo-picture-formats', () => { expect(element._getDownloadUrl()).to.equal(''); }); }); - - suite('fetch download url', () => { - test('Should fetch download url when item has downloadUrl property', () => { - const item = { - downloadUrl: 'abc.docx?changeToken=1-0&clientReason=download', - }; - expect(element._getDownloadUrl(item)).to.equal('abc.docx?changeToken=1-0&clientReason=download'); - }); - - test('Should fetch download url when item does not have downloadUrl property', () => { - const item = { - data: 'abc.docx?changeToken=1-0', - }; - expect(element._getDownloadUrl(item)).to.equal('abc.docx?changeToken=1-0'); - }); - test('Should not fetch download url when input is not provided', () => { - expect(element._getDownloadUrl()).to.equal(''); - }); - }); });