on_enter stopped working properly

[hrqmonteiro]

This is a minimal.lua i created:

-- Bootstrap lazy.nvim
local lazypath = vim.fn.stdpath("data") .. "/lazy/lazy.nvim"
if not (vim.uv or vim.loop).fs_stat(lazypath) then
  local lazyrepo = "https://github.com/folke/lazy.nvim.git"
  local out = vim.fn.system({ "git", "clone", "--filter=blob:none", "--branch=stable", lazyrepo, lazypath })
  if vim.v.shell_error ~= 0 then
    vim.api.nvim_echo({
      { "Failed to clone lazy.nvim:\n", "ErrorMsg" },
      { out, "WarningMsg" },
      { "\nPress any key to exit..." },
    }, true, {})
    vim.fn.getchar()
    os.exit(1)
  end
end
vim.opt.rtp:prepend(lazypath)

-- Make sure to setup `mapleader` and `maplocalleader` before
-- loading lazy.nvim so that mappings are correct.
-- This is also a good place to setup other settings (vim.opt)
vim.g.mapleader = " "
vim.g.maplocalleader = "\\"

local function jfunc()
  if vim.wo.diff then
    return "]c"
  else
  end
  local function _3_()
    return gitsigns.next_hunk()
  end
  vim.schedule(_3_)
  return "<Ignore>"
end

-- Setup lazy.nvim
require("lazy").setup({
  spec = {
	  {
		  "lewis6991/gitsigns.nvim",
		  config = function()
			  require("gitsigns").setup()
		  end
	  },
	  {
		  "nvimtools/hydra.nvim",
		  config = function()
			  local Hydra = require("hydra")
			  local gitsigns = require("gitsigns")

			  Hydra({
				  name = "+git",
				  body = "<leader>gh",
				  config = {
					  buffer = vim.bufnr,
					  color = "red",
					  invoke_on_body = true,
					  -- on_enter = function()
					  --  print("a")
					  -- end
				  },
				  heads = {
					{"J", jfunc, {desc = "next hunk", expr = true}}
				  }
			  })
		  end
	  }
  },
  -- Configure any other settings here. See the documentation for more details.
  -- colorscheme that will be used when installing plugins.
  install = { colorscheme = { "habamax" } },
  -- automatically check for plugin updates
  checker = { enabled = true },
})

And it works properly:

But when trying to pass a function on on_enter (uncommenting that section), it returns this error as soon as i open nvim:

I can't use on_enter or on_exit

[benlubas]

what neovim version?

[hrqmonteiro]

what neovim version?

NVIM v0.10.1
Build type: Release
LuaJIT 2.1.1713484068
Run "nvim -V1 -v" for more info

[aszakaly-vcc]

Upgrading to v0.10.2 worked for me.

[ColinKennedy]

Same error for me. I'm on

NVIM v0.11.0-dev-1157+g434d5936b6
Build type: RelWithDebInfo
LuaJIT 2.1.1731601260
Run ":verbose version" for more info

And it errors on startup with the Git example on the Wiki

Failed to run `config` for hydra.nvim

vim/shared.lua:0: s: expected string, got number

# stacktrace:
  - vim/shared.lua:0 _in_ **validate**
  - vim/shared.lua:0 _in_ **startswith**
  - vim/_init_packages.lua:0 _in_ **__index**
  - vim/shared.lua:0 _in_ **islist**
  - vim/shared.lua:0 _in_ ****
  - vim/shared.lua:0 _in_ **tbl_deep_extend**
  - /hydra.nvim/lua/hydra/layer/init.lua:116 _in_ **initialize**
  - /hydra.nvim/lua/hydra/lib/class.lua:14 _in_ **Layer**
  - /hydra.nvim/lua/hydra/init.lua:440 _in_ **_setup_pink_hydra**
  - /hydra.nvim/lua/hydra/init.lua:282 _in_ **initialize**
  - /hydra.nvim/lua/hydra/lib/class.lua:14 _in_ **Hydra**
  - lua/my_custom/plugins/hydra/configuration.lua:536
  - lua/my_custom/plugins/manifest/workflow.lua:362 _in_ **config**
  - init.lua:293

local Hydra = require("hydra")
local gitsigns = require('gitsigns')

local hint = [[
 _J_: next hunk   _s_: stage hunk        _d_: show deleted   _b_: blame line
 _K_: prev hunk   _u_: undo last stage   _p_: preview hunk   _B_: blame show full
 ^ ^              _S_: stage buffer      ^ ^                 _/_: show base file
 ^
 ^ ^              _<Enter>_: Neogit              _q_: exit
]]



Hydra({
   name = 'Git',
   hint = hint,
   config = {
      buffer = bufnr,
      color = 'pink',
      invoke_on_body = true,
      hint = {
         border = 'rounded'
      },
      on_enter = function()
         vim.cmd 'mkview'
         vim.cmd 'silent! %foldopen!'
         vim.bo.modifiable = false
         gitsigns.toggle_signs(true)
         gitsigns.toggle_linehl(true)
      end,
      on_exit = function()
         local cursor_pos = vim.api.nvim_win_get_cursor(0)
         vim.cmd 'loadview'
         vim.api.nvim_win_set_cursor(0, cursor_pos)
         vim.cmd 'normal zv'
         gitsigns.toggle_signs(false)
         gitsigns.toggle_linehl(false)
         gitsigns.toggle_deleted(false)
      end,
   },
   mode = {'n','x'},
   body = '<leader>g',
   heads = {
      { 'J',
         function()
            if vim.wo.diff then return ']c' end
            vim.schedule(function() gitsigns.next_hunk() end)
            return '<Ignore>'
         end,
         { expr = true, desc = 'next hunk' } },
      { 'K',
         function()
            if vim.wo.diff then return '[c' end
            vim.schedule(function() gitsigns.prev_hunk() end)
            return '<Ignore>'
         end,
         { expr = true, desc = 'prev hunk' } },
      { 's', ':Gitsigns stage_hunk<CR>', { silent = true, desc = 'stage hunk' } },
      { 'u', gitsigns.undo_stage_hunk, { desc = 'undo last stage' } },
      { 'S', gitsigns.stage_buffer, { desc = 'stage buffer' } },
      { 'p', gitsigns.preview_hunk, { desc = 'preview hunk' } },
      { 'd', gitsigns.toggle_deleted, { nowait = true, desc = 'toggle deleted' } },
      { 'b', gitsigns.blame_line, { desc = 'blame' } },
      { 'B', function() gitsigns.blame_line{ full = true } end, { desc = 'blame show full' } },
      { '/', gitsigns.show, { exit = true, desc = 'show base file' } }, -- show the base of the file
      { '<Enter>', '<Cmd>Neogit<CR>', { exit = true, desc = 'Neogit' } },
      { 'q', nil, { exit = true, nowait = true, desc = 'exit' } },
   }
})

[ColinKennedy]

Small update, getfenv() is no longer copying in the Neovim nightly. But it does copy in v0.10.2 As @aszakaly-vcc mentioned

repro is to clone neovim's github, git checkout nightly, then make, then ./build/bin/nvim -u NONE -c ':lua print(vim.tbl_deep_extend("keep", getfenv(), {}))'

And it errors with the same error. But it works if you git checkout v0.10.2 instead.

So I could see two routes forward. One would to be for Neovim core to fix it so getfenv() is copyable again. The other is for this plugin to exclude the key that is causing the break, which is getfenv()._G, and copy the other data instead. I don't know enough about hydra to know if not-copying the _G table is a viable solution.

[ColinKennedy]

Looks like this is a known issue:

neovim/neovim#30823

#46

This fork has a supposed fix (I haven't tested it yet): https://github.com/cathyprime/hydra.nvim