Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

messages/send does not support "from" field #542

Closed
jaencarrodine opened this issue Feb 27, 2024 · 1 comment · Fixed by #541
Closed

messages/send does not support "from" field #542

jaencarrodine opened this issue Feb 27, 2024 · 1 comment · Fixed by #541
Labels

Comments

@jaencarrodine
Copy link

Describe the bug
A clear and concise description of what the bug is.

The "from" user name cannot be set when sending emails.

To Reproduce
Some steps involved to reproduce the bug and any code samples you can share.

// Helps us with reproducing the error :)

await nylas.messages.send({
identifier: messagingAccountRes.data.grant_id,
requestBody: {
to: [{ email: to }],
subject: subject,
body: body,
//@ts-ignore
from: [{ email: , name: }],
},
})

Expected behavior
A clear and concise description of what you expected to happen.

BaseCreateMessage should be updated to include from field, from field should be passed to the sent email

SDK Version:
Providing the SDK version can help with the reproduction of the issue and to know if a change could have broken something.
7.1.0
Additional context
Add any other context about the problem here.

@mrashed-dev mrashed-dev linked a pull request Feb 27, 2024 that will close this issue
@mrashed-dev
Copy link
Contributor

@jaencarrodine thanks for opening this issue! We've opened a PR that should solve this, and will be available in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants