Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

component tiles throws error if camera not defined before 3d tiles entity #45

Open
kfarr opened this issue Mar 14, 2024 · 0 comments
Open

Comments

@kfarr
Copy link
Contributor

kfarr commented Mar 14, 2024

issue: when using with google tiles, if you attempt to place the entity with 3d tiles in an a-frame scene before the camera is defined in index.html you will get an error if you are referencing a camera element that is further down in the html.

psuedocode:
<a-camera id="cam">
<a-tiles entity camera=#cam>
good!

but
<a-tiles entity camera=#cam>
<a-camera id="cam">
bad!

instead: if the camera is not defined, the 3dtiles component should wait until the entire scene is loaded to see if one will be created instead of throwing an error immediately

kfarr added a commit to 3DStreet/3dstreet-editor that referenced this issue Mar 29, 2024
- NOTE: had to move reference layer down because of nytimes/aframe-loader-3dtiles-component#45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant